Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If ScrollY is selected the pdf button is doubled then #154

Closed
Jekastr opened this issue Oct 5, 2020 · 3 comments
Closed

If ScrollY is selected the pdf button is doubled then #154

Jekastr opened this issue Oct 5, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Jekastr
Copy link

Jekastr commented Oct 5, 2020

If ScrollY is selected the pdf button is doubled then.
Another thing I would like to point to is there is no paging button if ScrollY is selected. Yes I know this feature was removed intentionally but actually it was a good option even if you use it along with ScrollY. I am missing it.

@PrzemyslawKlys
Copy link
Member

Can you provide some sample code + screenshot for sake of having it?

Do you mean this change?

  • Improved New-HTMLTable - removed page button if DisablePaging or ScrollY is selected

What's the use case? How was it working? Maybe I made a mistake with my assumption on how it's working or not working in that case.

@Jekastr
Copy link
Author

Jekastr commented Oct 5, 2020

This is the piece of code that generated two PDF buttons
New-HTMLTable -DataTable $allAppsRep -Filtering -FilteringLocation bottom -DefaultSortIndex 0 -DefaultSortOrder Ascending -ScrollX -ScrollY -ScrollSizeY 300
Capture

As for page button I figured out, there are New-TableButton... commands that can be used for button panel customizations

BTW, thank you for your amazing module, I like it so much!

@PrzemyslawKlys PrzemyslawKlys added the bug Something isn't working label Oct 5, 2020
PrzemyslawKlys added a commit that referenced this issue Oct 6, 2020
@PrzemyslawKlys
Copy link
Member

To be honest, I don't understand the use case for paging - if I leave it on - nothing changes... when I switch the output. Can you elaborate what's your use case for ScrollY and Paging at the same time?

I'm also considering implementing Scroller -> https://datatables.net/extensions/scroller/ -> https://datatables.net/extensions/scroller/examples/initialisation/simple.html - it could be useful for performance reasons.

Problem with PDF x2 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants