Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit implementation of 2Din3D Hasegawa-Wakatani #232

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

oparry-ukaea
Copy link
Contributor

@oparry-ukaea oparry-ukaea commented Apr 12, 2024

Description

Implicit implementation of 2Din3D Hasegawa-Wakatani. Adapted from code in nektar-driftwave.
Requires nektar main at or after 8bc4b3095361e868b26219eff826d4f1902763df (07/03/2024).

Fixes #229

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

Add test - to do.

Test Configuration:

OS: Ubuntu 22.04
Compiler: GCC 11.3.0 / OneAPI v2022.1.0
SYCL implementation: Hipsycl v0.9.2 / DPC++ v2022.1.0
MPI details: MPICH v4.0.2
Hardware: CPU (Intel Alder Lake)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have used understandable variable names
  • I have run clang-format against my *.hpp and *.cpp changes
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@@ -250,12 +251,12 @@ class NeutralParticleSystem {
std::vector<int> components = {0};
m_field_project->project(syms, components);
if (m_low_order_project) {
FieldUtils::Interpolator interpolator{};
FU::InterpolatorSharedPtr interpolator;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a make_shared to actually call the constructor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep
Think I'll change it to what you have in #234 anyway - no real need for a shared pointer here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit version of the 2Din3DHW solver
2 participants