-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implicit implementation of 2Din3D Hasegawa-Wakatani #232
base: main
Are you sure you want to change the base?
Conversation
…f for some reason.
@@ -250,12 +251,12 @@ class NeutralParticleSystem { | |||
std::vector<int> components = {0}; | |||
m_field_project->project(syms, components); | |||
if (m_low_order_project) { | |||
FieldUtils::Interpolator interpolator{}; | |||
FU::InterpolatorSharedPtr interpolator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a make_shared to actually call the constructor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
Think I'll change it to what you have in #234 anyway - no real need for a shared pointer here
Description
Implicit implementation of 2Din3D Hasegawa-Wakatani. Adapted from code in nektar-driftwave.
Requires nektar main at or after 8bc4b3095361e868b26219eff826d4f1902763df (07/03/2024).
Fixes #229
Type of change
Testing
Add test - to do.
Test Configuration:
OS: Ubuntu 22.04
Compiler: GCC 11.3.0 / OneAPI v2022.1.0
SYCL implementation: Hipsycl v0.9.2 / DPC++ v2022.1.0
MPI details: MPICH v4.0.2
Hardware: CPU (Intel Alder Lake)
Checklist:
clang-format
against my*.hpp
and*.cpp
changes