-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PartSysBase and SimpleSOL+particles tweaks #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N.B. I've only changed the parameter name in the SimpleSOL config file for now, since that's the only solver using PartSysBase at the moment. |
…r in the SimpleSOL/SOLWithParticles system.
Last commit just adds some explanation of how 'num_particles_total' is used in SimpleSOL. |
oparry-ukaea
changed the title
PartSysBase tweaks
PartSysBase and SimpleSOL+particles tweaks
Jun 25, 2024
Unit+Integration tests passed with hipsycl. |
will-saunders-ukaea
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move handling of particle output frequency into particle system base class.
Type of change
- [ ] Bug fix (non-breaking change)- [ ] New feature (non-breaking change which adds functionality)- [ ] API change (breaks downstream workflows and requires major semver bump)- [ ] Requires documentation updatesTesting
No new tests. Passes existing unit and integration tests.
Test Configuration:
OS: Ubuntu 22.04
Compiler: GCC 11.3.0 / OneAPI v2022.1.0
SYCL implementation: Hipsycl v0.9.2 / DPC++ v2022.1.0
MPI details: MPICH v4.0.2
Hardware: CPU (Intel Alder Lake)
Checklist:
clang-format
against my*.hpp
and*.cpp
changes- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] Any new dependencies are automatically built for users viacmake
- [ ] I have runcmake-format
against my changes toCMakeLists.txt
- [ ] I have runblack
against changes to*.py
- [ ] I have made corresponding changes to the documentation