Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOF-6690: convert setup.py -> pyproject.toml #76

Merged
merged 4 commits into from
Jun 29, 2023
Merged

SOF-6690: convert setup.py -> pyproject.toml #76

merged 4 commits into from
Jun 29, 2023

Conversation

mrakitin
Copy link
Contributor

chu-k
chu-k reviewed Jun 28, 2023
View reviewed changes
Copy link

@chu-k chu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be good to still include auto-generated requirements from the deps and optional deps using pip-compile (from pip-tools).

Base automatically changed from feature/SOF-6690 to dev June 28, 2023 23:37
@mrakitin mrakitin marked this pull request as ready for review June 29, 2023 00:02
@mrakitin mrakitin merged commit 6f8f15b into dev Jun 29, 2023
@mrakitin mrakitin deleted the SOF-6690-pyproject.toml branch June 29, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chu-k chu-k chu-k left review comments

@timurbazhirov timurbazhirov timurbazhirov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrakitin @timurbazhirov @chu-k