-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More precision needed in boundary I/O time.dat
file
#870
Comments
This issue is stale because it has been open 30 days with no activity. |
This issue is stale because it has been open 30 days with no activity. |
Merged
Closed in #947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we're using the native format for the boundary I/O files, then it writes out an text file called
time.dat
to index the iteration numbers against the simulation time. However, if the simulation proceeds long enough, there isn't enough precision in the file to accommodate the exact times. This is what it looks like withdt=0.25
and t>10000:This is not a huge problem, but there will be slight errors accumulating as it interpolates the boundary data against the wrong times.
The fix looks pretty straightforward, looks like we need to add a precision modifier to
amr-wind/amr-wind/wind_energy/ABLBoundaryPlane.cpp
Lines 537 to 539 in ef0a198
Let me look and see if this type of problem appears anywhere else.
Lawrence
The text was updated successfully, but these errors were encountered: