wall model refactor #335
wall model refactor #335
Conversation
michaeljbrazell
commented
Feb 5, 2021
•
michaeljbrazell
commented
- added more wall models
- I'm not fully confident in any of the non Moeng heat flux wall model implementations
- @jrood-nrel this will cause a small diff for abl_stable due to order of operations: taux * den * utau2 vs. taux * utau2 * den
| @@ -266,12 +267,19 @@ void ABLWallFunction::computeusingheatflux() | |||
|
|
|||
| ABLVelWallFunc::ABLVelWallFunc(Field&, const ABLWallFunction& wall_func) | |||
| : m_wall_func(wall_func) | |||
| {} | |||
| { | |||
| amrex::ParmParse pp("ShearStress"); | |||
There was a problem hiding this comment.
I would prefer not adding another namespace here. Instead use ABL.wall_shear_stress_type = moeng ?
| @@ -349,11 +379,17 @@ void ABLVelWallFunc::operator()(Field& velocity, const FieldState rho_state) | |||
|
|
|||
| ABLTempWallFunc::ABLTempWallFunc(Field&, const ABLWallFunction& wall_fuc) | |||
| : m_wall_func(wall_fuc) | |||
| {} | |||
| { | |||
| amrex::ParmParse pp("HeatFlux"); | |||
There was a problem hiding this comment.
Can reuse ABL.wall_shear_stress_type here? I don't think that we have a use-case where we would do things differently for vel/temperature, is there? So one input parameter would suffice?
| } | ||
| void ABLTempWallFunc::operator()(Field& temperature, const FieldState rho_state) |
There was a problem hiding this comment.
clang-format hopefully complained here
There was a problem hiding this comment.
it missed it!
| } else { | ||
| amrex::Abort("Shear Stress temperature wall model input mistake"); | ||
| } |
There was a problem hiding this comment.
We should check this during input parsing time and remove this else.
amr-wind/wind_energy/ShearStress.H
Outdated
| // | ||
| // ShearStress.H | ||
| // amr-wind | ||
| // | ||
| // | ||
|
|
There was a problem hiding this comment.
| // | |
| // ShearStress.H | |
| // amr-wind | |
| // | |
| // |
amr-wind/wind_energy/ShearStress.H
Outdated
| term1 = mo.utau * mo.kappa / mo.phi_h(); | ||
| } | ||
|
|
||
| AMREX_GPU_HOST_DEVICE amrex::Real |
There was a problem hiding this comment.
We should also add AMREX_DEVICE_FORCE_INLINE
amr-wind/wind_energy/ShearStress.H
Outdated
|
|
||
| struct ShearStressConstant | ||
| { | ||
| ShearStressConstant(amr_wind::MOData mo) |
There was a problem hiding this comment.
| ShearStressConstant(amr_wind::MOData mo) | |
| ShearStressConstant(const amr_wind::MOData& mo) |
avoid a copy here.
There was a problem hiding this comment.
Also should declare these constructors explicit
amr-wind/wind_energy/ShearStress.H
Outdated
| , theta_mean(mo.theta_mean) | ||
| , theta_surface(mo.surf_temp) | ||
| { | ||
| term1 = mo.utau * mo.kappa / mo.phi_h(); |
There was a problem hiding this comment.
This can be initialized in the constructor initialization list also.
| amrex::Real term1; | ||
| }; | ||
|
|
||
| struct ShearStressMoeng |
There was a problem hiding this comment.
May be add doxygen docs and assign them to ABL group?
