Improve performance and specs #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,4 +92,5 @@ | |||
| # # test failures related to randomization by passing the same `--seed` value | |||
| # # as the one that triggered the failure. | |||
| # Kernel.srand config.seed | |||
| # ActiveRecord::Base.logger = Logger.new(STDOUT) | |||
PoslinskiNet
requested changes
Jun 12, 2017
There was a problem hiding this comment.
In most cases, you check 1 DB query count (with 2 exceptions) after the context. You simplify it and use it globally after a little spec change (those 2 exceptions) with after context callback: https://relishapp.com/rspec/rspec-core/docs/hooks/before-and-after-hooks. However, great refactor 👍 .
|
@Exelord you can also consider tagging context if you don't want to have after(:context) setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will improve performance by reducing possible n-query requests.
FIX: #79
TODO: