Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Door Event #2267

Merged
merged 25 commits into from
May 30, 2024
Merged

Add Door Event #2267

merged 25 commits into from
May 30, 2024

Conversation

Rysik5318
Copy link
Contributor

No description provided.

@Misaka-ZeroTwo Misaka-ZeroTwo added enhancement New feature or request regarding-events An issue or PR targeting the Exiled Events project labels Nov 16, 2023
louis1706
louis1706 suggested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
DamagingDoor event already exist

@Rysik5318
Copy link
Contributor Author

image DamagingDoor event already exist

Should we move this event to `Door'?

@Rysik5318 Rysik5318 changed the title Add Door EVent Add Door Event Nov 16, 2023
@VALERA771
Copy link
Contributor

image DamagingDoor event already exist

Should we move this event to `Door'?

That event patches the same method so I think you need to merge your events with that patch

@louis1706
Copy link
Member

louis1706 commented Nov 17, 2023 •
edited
Loading

image DamagingDoor event already exist

Should we move this event to `Door'?

don't make breaking change
Also i thinks we shouldn't create an other class for door they should just be add inside Map or Player event

louis1706
louis1706 suggested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there BreakingChange this PR will need to wait Exiled 9 (or remove breaking change)

@louis1706 louis1706 added the Do not merge Don't merge this PR label Nov 17, 2023
@Rysik5318
Copy link
Contributor Author

I'll wait for Exiled 9.

@louis1706
Copy link
Member

I'll wait for Exiled 9.

ok i would love than next update they would use DamageHandler with Door lol would be more logic xD

@Rysik5318
Copy link
Contributor Author

xD

@NaoUnderscore NaoUnderscore added this to the Exiled 9 milestone Jan 15, 2024
@louis1706 louis1706 changed the base branch from dev to apis-rework February 4, 2024 21:10
@louis1706
Copy link
Member

I have fixed all the conflict

@louis1706 louis1706 self-requested a review May 18, 2024 13:38
@Misfiy Misfiy requested a review from VALERA771 May 30, 2024 06:12
@Misfiy Misfiy removed the Do not merge Don't merge this PR label May 30, 2024
@Misfiy Misfiy merged commit 71b3c9d into Exiled-Team:apis-rework May 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Misfiy Misfiy Misfiy left review comments

@Misaka-ZeroTwo Misaka-ZeroTwo Misaka-ZeroTwo left review comments

@louis1706 louis1706 Awaiting requested review from louis1706

@VALERA771 VALERA771 Awaiting requested review from VALERA771

Assignees

@Rysik5318 Rysik5318

Labels
enhancement New feature or request regarding-events An issue or PR targeting the Exiled Events project
Projects
EXILED Workflow
Status: Done
Milestone
Exiled 9
Development

Successfully merging this pull request may close these issues.
6 participants
@Rysik5318 @VALERA771 @louis1706 @Misaka-ZeroTwo @Misfiy @NaoUnderscore