Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scp3114::Dancing event #2333

Merged
merged 35 commits into from
May 30, 2024
Merged

Scp3114::Dancing event #2333

merged 35 commits into from
May 30, 2024

Conversation

VALERA771
Copy link
Contributor

No description provided.

@VALERA771
Copy link
Contributor Author

I think NewState setter can be removed. Or NewState at all can be

@louis1706 louis1706 added regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch labels Dec 15, 2023
@NaoUnderscore NaoUnderscore added this to the Exiled 9 milestone Jan 13, 2024
@NaoUnderscore NaoUnderscore changed the base branch from dev to apis-rework January 13, 2024 18:18
louis1706
louis1706 reviewed Feb 4, 2024
View reviewed changes
Copy link
Member

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SUGGESTION] is it possible to choose wish dance is made and possibly having an Enum for it ?

@VALERA771
Copy link
Contributor Author

[SUGGESTION] is it possible to choose wish dance is made and possibly having an Enum for it ?

As far as I tested, it'll cause some wierd bugs

@louis1706
Copy link
Member

[SUGGESTION] is it possible to choose wish dance is made and possibly having an Enum for it ?

As far as I tested, it'll cause some wierd bugs

So you can add the Dance play as getter

@VALERA771
Copy link
Contributor Author

[SUGGESTION] is it possible to choose wish dance is made and possibly having an Enum for it ?

As far as I tested, it'll cause some wierd bugs

So you can add the Dance play as getter

Not possible. Patching that method in any way will cause some bugs

NaoUnderscore
NaoUnderscore requested changes Apr 7, 2024
View reviewed changes
Exiled.API/Enums/DanceType.cs Outdated Show resolved Hide resolved
Exiled.API/Features/Roles/Scp3114Role.cs Outdated Show resolved Hide resolved
Exiled.API/Features/Roles/Scp3114Role.cs Outdated Show resolved Hide resolved
Exiled.API/Features/Roles/Scp3114Role.cs Outdated Show resolved Hide resolved
Exiled.Events/EventArgs/Scp3114/DancingEventArgs.cs Outdated Show resolved Hide resolved
Exiled.Events/EventArgs/Scp3114/DancingEventArgs.cs Outdated Show resolved Hide resolved
Exiled.Events/EventArgs/Scp3114/DancingEventArgs.cs Outdated Show resolved Hide resolved
Exiled.Events/Handlers/Scp3114.cs Outdated Show resolved Hide resolved
Exiled.Events/Handlers/Scp3114.cs Outdated Show resolved Hide resolved
VALERA771 and others added 11 commits April 11, 2024 00:16
@VALERA771 @NaoUnderscore
Update DanceType.cs
af2936a 
Co-authored-by: Nao <60253860+NaoUnderscore@users.noreply.github.com>
@VALERA771 @NaoUnderscore
Update Scp3114Role.cs
cd64ab0 
Co-authored-by: Nao <60253860+NaoUnderscore@users.noreply.github.com>
@VALERA771 @NaoUnderscore
Update Scp3114Role.cs
327f5b1 
Co-authored-by: Nao <60253860+NaoUnderscore@users.noreply.github.com>
@VALERA771 @NaoUnderscore
Update Scp3114Role.cs
61fdcc6 
Co-authored-by: Nao <60253860+NaoUnderscore@users.noreply.github.com>
@VALERA771 @NaoUnderscore
Update DancingEventArgs.cs
83d2fc7 
Co-authored-by: Nao <60253860+NaoUnderscore@users.noreply.github.com>
@VALERA771 @NaoUnderscore
Update DancingEventArgs.cs
d850e19 
Co-authored-by: Nao <60253860+NaoUnderscore@users.noreply.github.com>
@VALERA771 @NaoUnderscore
Update DancingEventArgs.cs
ff26234 
Co-authored-by: Nao <60253860+NaoUnderscore@users.noreply.github.com>
@VALERA771 @NaoUnderscore
Update Scp3114.cs
0c0a0a5 
Co-authored-by: Nao <60253860+NaoUnderscore@users.noreply.github.com>
@VALERA771 @NaoUnderscore
Update Scp3114.cs
f9e1107 
Co-authored-by: Nao <60253860+NaoUnderscore@users.noreply.github.com>
@louis1706
Merge branch 'apis-rework' into dancing
5eaf8b3
@louis1706
Merge branch 'apis-rework' into dancing
a843bd1
@VALERA771
Copy link
Contributor Author

We still have the biggest problem - how to name dance types

@louis1706
Copy link
Member

We still have the biggest problem - how to name dance types

https://github.com/creepycats/EmoteForAll-SL/blob/main/Types/Scp3114DanceType.cs

@Misfiy
Copy link
Contributor

Misfiy commented May 22, 2024

Change Scp3114Role::StatDancing to Scp3114Role::StartDancing

@VALERA771
Copy link
Contributor Author

We still have the biggest problem - how to name dance types

https://github.com/creepycats/EmoteForAll-SL/blob/main/Types/Scp3114DanceType.cs

Does the numeration right? We really rely on number of enum in this case

@VALERA771
minor spelling mistake
ef642b2 
This is the biggest error I've ever seen
@Misfiy Misfiy mentioned this pull request May 26, 2024
Merged
@Misfiy
Copy link
Contributor

Misfiy commented May 26, 2024

Does the numeration right? We really rely on number of enum in this case

Looks like it should be working

@Misfiy Misfiy merged commit cb40c52 into Exiled-Team:apis-rework May 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamalexrouse iamalexrouse iamalexrouse left review comments

@Misfiy Misfiy Misfiy approved these changes

@louis1706 louis1706 Awaiting requested review from louis1706

@NaoUnderscore NaoUnderscore Awaiting requested review from NaoUnderscore

Assignees

@VALERA771 VALERA771

Labels
regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch
Projects
EXILED Workflow
Status: Done
Milestone
Exiled 9
Development

Successfully merging this pull request may close these issues.
5 participants
@VALERA771 @louis1706 @Misfiy @NaoUnderscore @iamalexrouse