Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Fix building samples without webready #2963

Merged
merged 1 commit into from
May 10, 2024

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented May 10, 2024

If EXIV2_ENABLE_WEBREADY is false, the conntest sample can't be built, as its code depends on Exiv2::http which doesn't exist in a non-webready build.

Fixes #2961

@neheb neheb merged commit 79eb767 into Exiv2:main May 10, 2024
57 of 58 checks passed
@ferdnyc ferdnyc deleted the cmake-sample-build branch May 11, 2024 00:07
@kmilos
Copy link
Collaborator

kmilos commented May 17, 2024

@mergify backport 0.28.x

Copy link
Contributor

mergify bot commented May 17, 2024

backport 0.28.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake build fails if samples enabled but webready disabled, due to conntest sample dependency
3 participants