Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for specifying custom DataFetchers #152

Merged
merged 6 commits into from
Jan 24, 2019
Merged

Conversation

dariuszkuc
Copy link
Collaborator

No description provided.

@dariuszkuc dariuszkuc added the status: do not merge Do not merge until this is removed label Jan 23, 2019
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #152 into master will decrease coverage by 0.57%.
The diff coverage is 85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #152      +/-   ##
============================================
- Coverage      95.8%   95.23%   -0.58%     
+ Complexity      153      148       -5     
============================================
  Files            52       55       +3     
  Lines           501      504       +3     
  Branches        103      102       -1     
============================================
  Hits            480      480              
- Misses            5        7       +2     
- Partials         16       17       +1
Impacted Files Coverage Δ Complexity Δ
.../com/expedia/graphql/hooks/SchemaGeneratorHooks.kt 100% <ø> (ø) 0 <0> (ø) ⬇️
.../exceptions/UnsupportedDataFetcherFactoryConfig.kt 0% <0%> (ø) 0 <0> (?)
...edia/graphql/execution/DataFetcherFactoryConfig.kt 100% <100%> (ø) 0 <0> (?)
...m/expedia/graphql/execution/FunctionDataFetcher.kt 43.75% <100%> (ø) 5 <1> (?)
...otlin/com/expedia/graphql/SchemaGeneratorConfig.kt 100% <100%> (ø) 6 <1> (ø) ⬇️
...dia/graphql/generator/types/FunctionTypeBuilder.kt 85.18% <100%> (-1.03%) 11 <0> (ø)
...dia/graphql/generator/types/PropertyTypeBuilder.kt 83.33% <100%> (+14.91%) 3 <0> (-3) ⬇️
...phql/execution/KotlinDataFetcherFactoryProvider.kt 81.81% <81.81%> (ø) 3 <3> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d230fc...836ccdd. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #152 into master will increase coverage by 0.98%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #152      +/-   ##
============================================
+ Coverage      95.8%   96.79%   +0.98%     
+ Complexity      153      152       -1     
============================================
  Files            52       53       +1     
  Lines           501      499       -2     
  Branches        103      100       -3     
============================================
+ Hits            480      483       +3     
+ Misses            5        4       -1     
+ Partials         16       12       -4
Impacted Files Coverage Δ Complexity Δ
.../com/expedia/graphql/hooks/SchemaGeneratorHooks.kt 100% <ø> (ø) 0 <0> (ø) ⬇️
...dia/graphql/generator/types/PropertyTypeBuilder.kt 83.33% <100%> (+14.91%) 3 <0> (-3) ⬇️
...phql/execution/KotlinDataFetcherFactoryProvider.kt 100% <100%> (ø) 3 <3> (?)
...otlin/com/expedia/graphql/SchemaGeneratorConfig.kt 100% <100%> (ø) 6 <1> (ø) ⬇️
...dia/graphql/generator/types/FunctionTypeBuilder.kt 85.18% <100%> (-1.03%) 11 <0> (ø)
...m/expedia/graphql/execution/FunctionDataFetcher.kt 75% <100%> (ø) 9 <1> (?)
...pedia/graphql/generator/types/ObjectTypeBuilder.kt 100% <0%> (+5.88%) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d230fc...0196351. Read the comment docs.

@dariuszkuc dariuszkuc removed the status: do not merge Do not merge until this is removed label Jan 24, 2019
@smyrick smyrick added the changes: major Changes require a major version label Jan 24, 2019
@smyrick smyrick merged commit 92c58be into master Jan 24, 2019
@smyrick smyrick deleted the datafetcher branch January 24, 2019 18:09
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* Enable coroutine support in default KotlinDataFetcher

* Enable support for specifying custom DataFetchers

* fix compilation errors

* simplify KotlinDataFetcherFactoryProvider

* add accidentally removed data fetcher tests

* renaming variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: major Changes require a major version
Development

Successfully merging this pull request may close these issues.

2 participants