Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: abstract away creation of GraphQL context #346

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

dariuszkuc
Copy link
Collaborator

@dariuszkuc dariuszkuc commented Sep 18, 2019

📝 Description

Abstracts creation of GraphQL context by introducing GraphQLContextFactory interface and provides default WebFilter that utilizes it to populate GraphQL context in the reactor subscriber context.

🔗 Related Issues

#329 - Add new module graphql-kotlin-spring-server

@smyrick smyrick added the type: enhancement New feature or request label Sep 18, 2019
@smyrick
Copy link
Contributor

smyrick commented Sep 18, 2019

👍 No release yet of this package so we are good to update

Abstracts creation of GraphQL context by introducing GraphQLContextFactory interface and provides default WebFilter that utilizes it to populate GraphQL context in the reactor subscriber context.
@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #346 into master will decrease coverage by 0.05%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #346      +/-   ##
============================================
- Coverage     94.74%   94.69%   -0.06%     
- Complexity      316      320       +4     
============================================
  Files            94       96       +2     
  Lines          1123     1131       +8     
  Branches        203      203              
============================================
+ Hits           1064     1071       +7     
- Misses           20       21       +1     
  Partials         39       39
Impacted Files Coverage Δ Complexity Δ
...up/graphql/spring/execution/SubscriptionHandler.kt 94.44% <ø> (ø) 0 <0> (?)
...up/graphql/spring/SubscriptionAutoConfiguration.kt 100% <ø> (ø) 4 <0> (ø) ⬇️
...expediagroup/graphql/spring/RoutesConfiguration.kt 72% <ø> (ø) 11 <0> (ø) ⬇️
...ediagroup/graphql/spring/execution/QueryHandler.kt 75% <ø> (ø) 0 <0> (?)
.../graphql/spring/execution/GraphQLContextFactory.kt 100% <100%> (ø) 0 <0> (?)
...iagroup/graphql/spring/GraphQLAutoConfiguration.kt 87.5% <100%> (+1.78%) 6 <2> (+2) ⬆️
...group/graphql/spring/execution/ContextWebFilter.kt 75% <75%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a179f5...22138e9. Read the comment docs.

@dariuszkuc dariuszkuc merged commit cb1cc33 into ExpediaGroup:master Sep 18, 2019
@dariuszkuc dariuszkuc deleted the boot_server branch September 18, 2019 17:38
@smyrick smyrick added the changes: minor Changes require a minor version label Sep 24, 2019
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Abstracts creation of GraphQL context by introducing GraphQLContextFactory interface and provides default WebFilter that utilizes it to populate GraphQL context in the reactor subscriber context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants