Fix subscriptions messaging and tests #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrick
added
type: bug
smyrick
force-pushed
the
subscriptions-tests
branch
from
7106d73
to
1204c73
Compare
dariuszkuc
reviewed
Aug 31, 2020
dariuszkuc
reviewed
Aug 31, 2020
examples/spring/src/main/kotlin/com/expediagroup/graphql/examples/dataloaders/CompanyService.kt
Show resolved
Hide resolved
smyrick
force-pushed
the
subscriptions-tests
branch
from
5092006
to
24c0a6b
Compare
Working test publishers with mono, not flux Trigger complete call on server complete message Fix linter Undo changes from PR Update linter Update bean usage of data loader tests Update spring and spring boot version Fix example tests
smyrick
force-pushed
the
subscriptions-tests
branch
from
5324daf
to
e5a29a3
Compare
dariuszkuc
approved these changes
Sep 1, 2020
huehnerlady
pushed a commit
to huehnerlady/graphql-kotlin
that referenced
this pull request
Oct 16, 2020
Working test publishers with mono, not flux Trigger complete call on server complete message Fix linter Undo changes from PR Update linter Update bean usage of data loader tests Update spring and spring boot version Fix example tests Co-authored-by: Shane Myrick <accounts@shanemyrick.com>
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Working test publishers with mono, not flux Trigger complete call on server complete message Fix linter Undo changes from PR Update linter Update bean usage of data loader tests Update spring and spring boot version Fix example tests Co-authored-by: Shane Myrick <accounts@shanemyrick.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
When updating to the latest spring boot version our subscription tests are failing. I can reproduce this with just the jump to Spring Boot
2.2.7.The issue is that the
StepVerifiers do not complete the publisher so the test stays running in the background and never completes. I have re-worked how to capture the published events in the tests, as well as fixed a bug in the subscription code that was not sending theCOMPLETEevent. However this still hangs when we are trying to process multiple events.The line here, using
toMonostop the publisher after just one event which is why it fails when attempting to check the second message. However after usingtoFluxthe test never completes. If I manually stop it the test has actually passed as all the data was present and completed, but the test is still waiting.If someone else can help investigate or knows the Reactor methods better than I do, it would be very helpful to figure what we have to do in these integration tests. The code outside integration tests looks good.
🔗 Related Issues
#835