Add instructions for a standard kubernetes setup #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldtiki
changed the title
nikos912000
reviewed
Apr 18, 2020
nikos912000
reviewed
Apr 18, 2020
docs/installation/kubernetes.md
Outdated
| - name: SERVER_PORT | ||
| value: "9411" | ||
| - name: JAVA_JVM_ARGS | ||
| value: "-Dspring.jmx.enabled=true -XX:MaxRAMPercentage=80.0" |
There was a problem hiding this comment.
I see we've enabled JMX for metrics, but do we really need it?
Setting spring.jmx.enabled to true adds some overhead (see here) and wondering if it's useful or not.
There was a problem hiding this comment.
the kafka metrics require this to be enabled :(
There was a problem hiding this comment.
regarding the metrics, there's folks using jmx agents to get metrics.
nikos912000
reviewed
Apr 18, 2020
nikos912000
reviewed
Apr 18, 2020
docs/installation/kubernetes.md
Outdated
| prometheus.io/port: "8081" | ||
| prometheus.io/path: "/actuator/prometheus" | ||
| spec: | ||
| terminationGracePeriodSeconds: 0 |
There was a problem hiding this comment.
I think this needs to be > preStop hook sleep duration. By default it's 30s.
Kubernetes waits for time=terminationGracePeriodSeconds and this happens in parallel to whatever we set in the preStop hook.
There was a problem hiding this comment.
yes, you're right. i'll remove this line.
nikos912000
reviewed
Apr 18, 2020
Co-Authored-By: Nikos Katirtzis <nkatirtzis@expediagroup.com>
Co-Authored-By: Nikos Katirtzis <nkatirtzis@expediagroup.com>
nikos912000
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Instructions for a standard kubernetes setup