[HOLD for payment 2023-08-07] [$8000] The message got sent but it also stayed in the compose box

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Type something
2. Press the send icon
3. Right after pressing the send icon, start typing again quickly without any break. The compose box will still have the text you just sent

Expected Result:

Compose box should clear

Actual Result:

Compose box doesn't clear

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.85-8
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
related to #4129

RPReplay_Final1659025442.MP4

Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1658727800463809

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pecanoro]

I was able to reproduce on my phone, so assigning external.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mateusbra]

I think its duplicate of #4129

[mountiny]

I think its duplicate of #4129

@mateusbra Thanks! We are aware of that, it is mentioned in the issue body. That issue got very long and hard to follow so we decided to make a clean start and just refer to it. Lots of time has passed since then so maybe easier and cleaner solutions will pop up.

[dhairyasenjaliya]

This #8592 (comment) proposal I have explained why this happens and also provided a solution (except mobile safari) that can solve this issue, as well as another issue, of blue opacity issue, remains in iOS after spell check #8592

[melvin-bot]

@dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[dylanexpensify]

Getting on it today

[dylanexpensify]

Internal: https://www.upwork.com/ab/applicants/1554462059426074624/job-details
External: https://www.upwork.com/jobs/~0130f26b3941d0c325

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @AndrewGable (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

This #8592 (comment) proposal I have explained why this happens and also provided a solution (except mobile safari) that can solve this issue, as well as another issue, of blue opacity issue, remains in iOS after spell check #8592

@dhairyasenjaliya I'm sorry, I'm not sure if I understand.

Can you please write up a proposal on this issue, thanks!

[dhairyasenjaliya]

actually this issue I have discussed here #8592 (comment) before, but I have not reported this bug on slack and also I did write a proposal there in order to solve

Currently, I'm waiting for the internal team here #8592 (comment) they decide to split mWeb and iOS as 2 separate issues once I get to know what's next step I will notify you here as well

CC @rushatgabhane

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• #10148 — The message got sent but it also stayed in the compose box #22227

If no regressions arise, payment will be issued on 2023-08-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @tomekzaw does not require payment (Contractor)
• @rushatgabhane does not require payment (Eligable for Manual Requests)
• @robertKozik does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @robertKozik] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rojiphil]

Referring to this slack entry here, it does not look like this issue is resolved with the current fix.

[rushatgabhane]

@rojiphil looks like that bug report is 2 days ago. But the fix was deployed to production today.

Commented in slack if they can still repro it.

Not reproducible on latest release V1.3.48-5

screen-20230803-100700.mp4

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Not a regression. It was always present.

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. N.A.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Created a manual request on new dot - https://staging.new.expensify.com/r/5267744771377329

[ahmdshrif]

Since this is done.... just a reminder that I was the first reporter for this issue as I mention here.

[roryabraham]

@dylanexpensify should we pay a bug reporting bonus to @ahmdshrif ?

[JmillsExpensify]

Related, can you summarize the appropriate payments for everyone on this issue?

[dylanexpensify]

Yes! Sorry, got stuck with travel yesterday!

[dylanexpensify]

Payment summary:

• @ahmdshrif Reporting Bonus: $250
• @rushatgabhane C+ Review: $8,000

Upwork job is here.

[ahmdshrif]

@dylanexpensify applied.

[Fco18]

Hello, my name is Francisco Castellanos. I am a systems engineering student and a junior web designer. I saw the job posting and I believe it fits well with my profile. I have completed courses in HTML, CSS, JavaScript, MongoDB, PHP, React, and Node.js.

[melvin-bot]

📣 @Fco18! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[dylanexpensify]

@ahmdshrif sent offer!

[JmillsExpensify]

Reviewed the details for @rushatgabhane. This amount is approved for payment in NewDot.

[ahmdshrif]

@dylanexpensify accepted!

[dylanexpensify]

Payments/contracts done!

[aimane-chnaif]

Seems like issue still exists. There are multiple bug reports for this.
i.e. Text remains in composer after clicking send

@c3024 maybe you can help with consistent reproducible step here.

[c3024]

@aimane-chnaif
On a physical device or emulator, keep pressing/typing continuously with one hand and press send again and again continuously with the other hand.
Sometimes, Send triggers and sends messages but the composer is not cleared.