[HOLD for payment 2022-11-16] [$500] IPAD: Extra space on the above attachment - reported by @ahmdshrif

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app ( on iPad landScape)
2. go to any chat
3. send pdf
4. open the pdf file

Expected Result:

No extra space above the attachment like other platforms.

Actual Result:

There is extra space as shown on the screenshot.

Workaround:

unknown.

Platform:

Where is this issue occurring?

• iOS (IPAD)

Version Number: 1.1.88-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @ahmdshrif

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1658374757439919

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

Seems like a fairly straightforward fix, doubt it was a regression so marking as external

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Christinadobrzyn]

Job created in Upwork -

Internal job posting - https://www.upwork.com/ab/applicants/1559027292353654784/job-details
External job posting - https://www.upwork.com/jobs/~01e3e6cbb28903b6fd

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[melvin-bot]

Triggered auto assignment to @Gonals (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[vfurkanguner]

PROPOSAL

I reproduce the problem. The problem seems to be related only to padding. But if we remove the padding, I haven't tested what kind of problem will occur on other screens.

[melvin-bot]

Current assignee @shawnborton is eligible for the Design assigner, not assigning anyone new.

[Christinadobrzyn]

Looks like the PR is up - #12130

@mananjadhav @shawnborton @Gonals where are we with reviewing the PR? Can we get an update on what needs to happen to get this finished?

[mananjadhav]

@Christinadobrzyn The changes I reviewed, I am currently testing them. I'll take me a day or two to finish testing on all platforms

[mananjadhav]

C+ Review done on the PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

• A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
• The PR that introduced the bug has been identified. Link to the PR:
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• Payment has been made to the issue reporter (if applicable)
• Payment has been made to the contributor that fixed the issue (if applicable)
• Payment has been made to the contributor+ that helped on the issue (if applicable)

[mananjadhav]

I don't think I would call this a bug. We've always had the padding adjusted this way and then with the discussions above, we've refactored the UI to remove the padding altogether.

[Christinadobrzyn]

I have no idea how to complete most of that BugZero Checklist - asking here: https://expensify.slack.com/archives/C01SKUP7QR0/p1667981905951189

@mananjadhav would you happen to know:

• The PR that introduced the bug has been identified.
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.25-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• remove extra spaces on attachment modal #12130

If no regressions arise, payment will be issued on 2022-11-16. 🎊

[mananjadhav]

@Christinadobrzyn I can say we never design the AttachmentView for iPad. Hence, the fix was to also refactor the component to remove all the padding. Do you still need the PR?

[aimane-chnaif]

Am I eligible for some more compensation for this issue? Since lots of discussions happened and final spec is beyond the original issue.

[Christinadobrzyn]

@mananjadhav that might be a question for @Gonals
@aimane-chnaif what do you think is fair compensation for the work you've done - I can discuss with our team.

[Gonals]

padding adjusted this way and then with the discussions above, we've refactored the UI to remove the padding altogether.

I don't think we need the PR in this case, since it wasn't really a bug, just a change in design down the line.

[mananjadhav]

Agreed @Gonals.

Am I eligible for some more compensation for this issue? Since lots of discussions happened and final spec is beyond the original issue.

Agree here with @aimane-chnaif. @aimane-chnaif Did you get a chance to look at @Christinadobrzyn's comment here

[aimane-chnaif]

what do you think is fair compensation for the work you've done - I can discuss with our team.

@Christinadobrzyn I was thinking of $750-$1000. But it would depend on your judgement. Thanks

[Christinadobrzyn]

Thanks for the extra information @aimane-chnaif I reached out to our team to get some thoughts. I'll follow up as soon as I have more information from them and pay this.

[mananjadhav]

@Christinadobrzyn do you have any updates for us here?

[Christinadobrzyn]

Sorry for the delay. Closed the job in Upwork and closing this.

I paid
@aimane-chnaif $750 for the fix
@mananjadhav $750 as the C+
@ahmdshrif $250 for reporting the bug

Let me know if you have any questions!

[Christinadobrzyn]

Hey @mananjadhav sorry, I missed your question here #10352 (comment)

Yes, can you please send me the PR that caused the issue so I can record it in test rail.

[mananjadhav]

Yes, can you please send me the PR that caused the issue so I can record it in test rail.

Please check the response here