[HOLD for payment 2022-12-02] [$250] Link with trailing spaces doesn't got trimmed reported by @kerupuksambel

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open staging.new.expensify.com
2. Send a link on Markdown with trailing spaces for its URL title (for example, test )

Expected Result:

The URL title should be trimmed

Actual Result:

The URL title isn't trimmed

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.24-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @kerupuksambel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1667742263937549

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[0xmiros]

Proposal

https://github.com/Expensify/expensify-common/blob/805a4c34debc7e27b14e33847ac4df4d59b6d878/lib/ExpensiMark.js#L68-L92

-                   return `<a href="${g3 && g3.includes('http') ? '' : 'https://'}${g2}" target="_blank" rel="noreferrer noopener">${g1}</a>`;
+                   return `<a href="${g3 && g3.includes('http') ? '' : 'https://'}${g2}" target="_blank" rel="noreferrer noopener">${g1.trim()}</a>`;

[abekkala]

I was able to reproduce.

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @neil-marcellini (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[abekkala]

https://www.upwork.com/ab/applicants/1589672953567510528/job-details
https://www.upwork.com/jobs/~01e4cfeb9fae72404b

[rushatgabhane]

@neil-marcellini i recommend @0xmiroslav's proposal.

🎀 👀 🎀 C+ reviewed

[neil-marcellini]

@neil-marcellini i recommend @0xmiroslav's proposal.

🎀 👀 🎀 C+ reviewed

I agree, it looks good. We will also need to update the package.json once the expensify-common PR is merged.

App/package.json

Line 70 in 077304b

"expensify-common": "git+https://github.com/Expensify/expensify-common.git#6010b3c49a16f63ee9cecc0c720f6d10395775ef",

[melvin-bot]

📣 @0xmiroslav You have been assigned to this job by @neil-marcellini!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[abekkala]

@neil-marcellini can I confirm that we're waiting for the proposal in Upwork before I can do the hiring task?

[neil-marcellini]

I think you should be on this SO step?

[abekkala]

Ah got it.
The three have been hired via Upwork

[melvin-bot]

@abekkala, @neil-marcellini, @rushatgabhane, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

@neil-marcellini do yo know why this hasn't auto-populated a payment date in the GH title?

[neil-marcellini]

@abekkala That webhook only triggers when there's a new release of the App. Actually that reminds me that we still need to update the package.json in app to use the update version of expensify-common as I mentioned here. @0xmiroslav could you please put up a PR for that update?

Sorry about that April. We should only pay after the App PR is merged. Once it is merged the "HOLD for payment" text and the date will show in the title. All you need to do is wait until that date to issue payments.

[neil-marcellini]

The last PR we need got merged and will be deployed soon.

[melvin-bot]

@abekkala, @Gonals, @neil-marcellini, @rushatgabhane, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[neil-marcellini]

The App PR was deployed to production. I'm not sure why the checklist didn't post automatically so here it is.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@neil-marcellini / @rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
  N/A this was not a regression, it was overlooked during the initial implementation.
• [@neil-marcellini / @rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  N/A same as above.
• [@neil-marcellini / @rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion in Slack here.
• [@abekkala] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[abekkala]

@neil-marcellini it looks like the PR was merged but the payment wasn't updated for title, is that correct?

[neil-marcellini]

Yes

[abekkala]

Looks like that occurred 4 days ago on Nov 25 so payment is on hold until Dec 02

[abekkala]

Not overdue. payment is today

[abekkala]

Payments were sent to @0xmiroslav , @rushatgabhane and @kerupuksambel

We're all set here. Closing

Thank you! 🎉

[0xmiros]

I think timeline bonus can be applied here
assigned on Nov 9 (#12511 (comment))
merged on Nov 14 (Expensify/expensify-common#471 (comment))

[abekkala]

@0xmiroslav
I had noted that assignment was on Nov 9 and merged on Nov 14.
That is 5 days.

Merged PR within 3 business days receive a 50% bonus

Your merge was not within 3 business days.

[0xmiros]

@abekkala there was a weekend in between

[abekkala]

ah yes yes, sorry!

[abekkala]

@0xmiroslav @rushatgabhane are to receive a 50% bonus ($125 each)

[abekkala]

[abekkala]

@0xmiroslav you've been paid the bonus! 🎉

[abekkala]

@rushatgabhane you've been paid the bonus! 🎉

[0xmiros]

@0xmiroslav you've been paid the bonus! 🎉

Thanks