Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$2000] Android - Chat - Unable to enter password for protected Pdf file #18151

Closed
1 of 6 tasks
kbecciv opened this issue Apr 28, 2023 · 39 comments
Closed
1 of 6 tasks

[$2000] Android - Chat - Unable to enter password for protected Pdf file #18151

kbecciv opened this issue Apr 28, 2023 · 39 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Apr 28, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Upload one Pdf protected file twice
  4. Open in view mode but don't enter password
  5. Press forward and back arrows several times
  6. Press enter password

Expected Result:

User can enter a password or return to viewing files in the chat.

Actual Result:

View mode closed and you need to restart the App to open PDF protected files.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.8.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6035427_Screen_Recording_20230428_181352_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0144c971f1de5f8a16
  • Upwork Job ID: 1655709835480170496
  • Last Price Increase: 2023-05-22
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 28, 2023
@MelvinBot
Copy link

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 28, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@MitchExpensify
Copy link
Contributor

I am unable to reproduce this using the steps in OP
image

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2023
@MitchExpensify MitchExpensify added the Needs Reproduction Reproducible steps needed label May 1, 2023
@melvin-bot melvin-bot bot added the Overdue label May 4, 2023
@MitchExpensify
Copy link
Contributor

Still needs reproduction, @kbecciv can you reproduce still?

@melvin-bot melvin-bot bot removed the Overdue label May 4, 2023
@kbecciv
Copy link
Author

kbecciv commented May 4, 2023

Hello @MitchExpensify Checking with team, will update you shortly.

@MitchExpensify
Copy link
Contributor

Thank you!

@melvin-bot melvin-bot bot added the Overdue label May 8, 2023
@kbecciv
Copy link
Author

kbecciv commented May 8, 2023

@MitchExpensify Able to reproduced in SG21/13 using build 1.3.11.2 when opened first uploaded PDF file, please attached the video.

Screen_Recording_20230508_184414_New.Expensify.mp4

@MitchExpensify
Copy link
Contributor

Thank you!

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2023
@MitchExpensify
Copy link
Contributor

Looking to see if this is a dupe turned up:

#16694
#15896

Both are related to password protected PDFs but not the same issue exactly.

@MitchExpensify MitchExpensify added the External Added to denote the issue can be worked on by a contributor label May 8, 2023
@melvin-bot melvin-bot bot changed the title Android - Chat - Unable to enter password for protected Pdf file [$1000] Android - Chat - Unable to enter password for protected Pdf file May 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 8, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0144c971f1de5f8a16

@melvin-bot
Copy link

melvin-bot bot commented May 8, 2023

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 8, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 8, 2023

Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@flodnv
Copy link
Contributor

flodnv commented May 9, 2023

So @MitchExpensify :

  1. Did you reproduce?
  2. Did you ask the other people involved if they are related?

@parasharrajat
Copy link
Member

It might be related to specific devices as only Android is affected (as per the OP). Samsung devices always have strange bugs.

  • Did we check other platforms?

@MitchExpensify
Copy link
Contributor

@flodnv I cannot reproduce and I think its to do with using BrowserStack so thats why I asked if it was still reproducible here.

I didn't ask in those issues if they are related because it seemed to me like they were not.

@flodnv
Copy link
Contributor

flodnv commented May 9, 2023

Why do you think it has to do with BrowserStack?

@kbecciv did you test on a real device? Can you reproduce on a device that is Android, but not Samsung?

@kbecciv
Copy link
Author

kbecciv commented May 10, 2023

Hello @flodnv! Yes, I can ask QA team to test with different devices, will update you shortly with results.

@MitchExpensify
Copy link
Contributor

Why do you think it has to do with BrowserStack?

Uploading a password protected PDF via BrowserStack felt janky. So I figured it was safer to get someone with a physical device to double check reproduction.

Thanks for seeing if others can reproduce @kbecciv !

@kbecciv
Copy link
Author

kbecciv commented May 10, 2023

Issue is not reproductible on Redmi Note 9/Android 11

Screenrecorder-KI.1.mp4

@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

@flodnv @parasharrajat @MitchExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@MitchExpensify
Copy link
Contributor

Ok given this seems to be specific to Samsung, and not reproducible on other Android devices I'm not sure what to do next. Looking for a bug zero buddy check on this one, curious for your thoughts @mallenexpensify 👁️

@parasharrajat
Copy link
Member

parasharrajat commented May 14, 2023

https://www.counterpointresearch.com/global-smartphone-share/ Given that Samsung is used by millions of people, we should solve this.

@flodnv
Copy link
Contributor

flodnv commented May 15, 2023

I tend to agree, however it sounds like we can only reproduce on a physical samsung device...?

@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@parasharrajat
Copy link
Member

parasharrajat commented May 15, 2023

however it sounds like we can only reproduce on a physical samsung device...

Normally app is used on real devices.

What is the next step here @MitchExpensify?

@MitchExpensify
Copy link
Contributor

I'll test again now trying to use the same device via browserstack..

@MitchExpensify
Copy link
Contributor

@MitchExpensify Able to reproduced in SG21/13 using build 1.3.11.2 when opened first uploaded PDF file, please attached the video.

Browserstack doesn't have an option to use the same device @kbecciv used..

image

I'll try some other Samsungs that are available 👁️

@MitchExpensify
Copy link
Contributor

I cannot reproduce on Galaxy S21 11, I am not sure what else to try at this point. Any thoughts on this @mallenexpensify ?

@flodnv
Copy link
Contributor

flodnv commented May 17, 2023

@MitchExpensify can you bring this to Slack?

@MitchExpensify
Copy link
Contributor

Yes!

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

@flodnv @parasharrajat @MitchExpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@parasharrajat
Copy link
Member

@MitchExpensify can you please increase the price here? We haven't received any proposals yet.

@flodnv
Copy link
Contributor

flodnv commented May 22, 2023

Bumped the internal discussion here: https://expensify.slack.com/archives/C03TQ48KC/p1684769168199199

@flodnv flodnv changed the title [$1000] Android - Chat - Unable to enter password for protected Pdf file [$2000] Android - Chat - Unable to enter password for protected Pdf file May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Upwork job price has been updated to $2000

@flodnv
Copy link
Contributor

flodnv commented May 22, 2023

@kbecciv do you have any other samsung device to test, ideally one of these #18151 (comment) ?

@kbecciv
Copy link
Author

kbecciv commented May 23, 2023

@flodnv Sorry, I don't have other Samsung device.

@MitchExpensify
Copy link
Contributor

Closing based on internal discussion https://expensify.slack.com/archives/C01SKUP7QR0/p1684418768822779

@flodnv
Copy link
Contributor

flodnv commented May 23, 2023

@MitchExpensify I think a summary is in order

Basically, because no one can reproduce this, then we can't fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants