[HOLD for checklist] [$1000] Year search page of date of birth field has darker overlay color than other side menus or popups

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings and observe that chat and LHN fades with darker tint over it (that is the overlay color)
3. Open profile
4. Open personal details
5. Open date of birth
6. Open year search and observe that it has darker overlay then any other sidemenus or popup throughout the app

Expected Result:

App should keep same overlay color throughout the app for all sidemenus and popups

Actual Result:

Year search page of date of birth field in personal details has darker overlay color then any other sidemenus or popups

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14-14
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

darker.overlay.over.year.search.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684227390734479

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139c82137536ac15d
• Upwork Job ID: 1661495698881851392
2023-07-20
• Automatic offers:
• aimane-chnaif | Reviewer | 25753594
• dhanashree-sawant | Reporter | 25753596

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

I think it would be better to consult the design team on the expected behaviour.

[JmillsExpensify]

Apologies, I got assigned these during EC3 and I wasn't able to find time during the conference to triage. I'm now OOO for the rest of the week, so I'm going to re-apply the bug label so that someone that's more available can help move this forward. Thanks!

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[strepanier03]

Okay, working on this now.

[strepanier03]

@Expensify/design - Can you please take a look at this one for expected behavior.

I actually think this makes sense that the overlay gets darker the deeper down menus you get, but if it's the only place we're going this dark maybe it's unintended.

Following the steps in the OP comment can be used to recreate this no problem.

[strepanier03]

Folks are coming back from EC3 so giving this another day before I bump again.

[strepanier03]

I raised this for discussion here, but because so many voices are currently out of the office this might not move forward until more are back online.

[strepanier03]

Going to move this forward and ask that we apply the same consistent overlay style to the Year page as the other menu pages.

@shawnborton - If you disagree with this decision let us know when you get back. We'll have plenty of time pausing moving forward if we need to but just in case this is the right choice we'll get a jump on correcting it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0139c82137536ac15d

[melvin-bot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[loveheenavasu]

Proposal

Please re-state the problem that we are trying to solve in this issue.
Year search page of date of birth field in personal details has darker overlay color then any other sidemenus or popups

What is the root cause of that problem?
When we select the Year in the calendar, there is multiple screen overlay added to the screen which is making the background overlay darker

What changes do you think we should make in order to solve the problem?
In AuthScreens.js there are modalScreenOptions added to Select_Year. Please refer to the below code.

<RootStack.Screen
                    name="Select_Year"
                    options={modalScreenOptions}
                    component={ModalStackNavigators.YearPickerStackNavigator}
                    listeners={modalScreenListeners}
                />

There is an option named cardOverlayEnabled in modalScreenOptions. so we can spread the modalScreenOptions and make the cardOverlayEnabled false.

This will solve the problem. Please refer to the video attached.

Untitled.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent unnecessary overlay from being added while opening RIGHT_DOCKED modals #24361

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter -- @dhanashree-sawant has been paid $250 👍
• Contributor that fixed the issue -- @HezekielT qualified for the bonus, and they have been paid $1,500 👍
• Contributor+ that helped on the issue and/or PR -- @aimane-chnaif qualified for the bonus, and they have been paid $1,500 👍

For reference, here are some details about the assignees on this issue:

• @pasyukevich does not require payment (Contractor)
• @HezekielT requires payment
• @aimane-chnaif requires payment offer (Reviewer)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

@HezekielT just sent you the contract in Upwork. Please let me know once you accept, so I can send the payment — TIA!

@aimane-chnaif and @dhanashree-sawant, both of you should have received your payments 👍

[HezekielT]

@CortneyOfstad Thanks, I've accepted the offer. I think this is also eligible for the bonus according to this comment if I'm not mistaken.

[CortneyOfstad]

All payments have been made! Just waiting for the checklist, and then we are set!

[situchan]

@CortneyOfstad I think I am eligible for reporting bonus.
This issue was closed as fixed while navigation refactor and first bug reporter got paid.
After a while, issue reproduced again and I reported in slack - https://expensify.slack.com/archives/C049HHMV9SM/p1689171550118729.
And this made @kbecciv reopen this issue - #19073 (comment)

Issue reporter was not updated because of this:

[CortneyOfstad]

Is this correct @kavimuru? ^^^

[CortneyOfstad]

Also @aimane-chnaif — do you have an update on the checklist?

[CortneyOfstad]

Bump @kavimuru and @aimane-chnaif ^^^

[aimane-chnaif]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: Refactor new date picker #21792
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor new date picker #21792 (comment)
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This came from date picker refactor. This is minor UI inconsistency which doesn't affect users, so no regression test is needed.

[aimane-chnaif]

@CortneyOfstad it's true that this issue was closed as fixed and then re-opened by @situchan's bug report on slack.
Original bug reporter @dhanashree-sawant was also paid - #19073 (comment)

[CortneyOfstad]

Thanks @aimane-chnaif!

@situchan I sent you over the contract in Upwork — please let me know as soon as you accept so I can get that paid ASAP. Thanks!

[melvin-bot]

@cead22, @CortneyOfstad, @pasyukevich, @HezekielT, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

Just saw that @situchan accepted the contract so that has been paid in Upwork! No additional action needed, so closing!