[$500] mWeb/Safari - Edit message - Text input not focused & keypad doesn't appear when edit message box activated

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Navigate to any conversation
3. Tap and hold on sent message to view the action menu
4. Tap on the Pencil icon to activate the edit message box

Expected Result:

As per step 4, the text input is focused and the keyboard appears for mobile when edit message box is activated

Actual Result:

Text input not focused & keypad doesn't appear when edit message box activated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6294978_1701281839860.SYRC8491.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013eec6f943cbf57c0
• Upwork Job ID: 1729936507297144832
• Last Price Increase: 2023-11-29

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013eec6f943cbf57c0

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[shreyfirst]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the text input to be focused and keyboard to be shown when the Edit Message button is pressed.

What is the root cause of that problem?

The issue is that we are not indicating that the text box should be focused (aside from the UI showing it is, the browser is not focusing it) when you click the menu item. We're specifically handling for mWeb/Safari in this specific issue as the DOM hasn't loaded at this point.

What changes do you think we should make in order to solve the problem?

On the initial load of the message edit component, we should add a check to make sure that the input is in the DOM and ready to be focused before we update the selection prop. We will also look for how other parts of the code interact with the input to see if it might be causing the input to lose focus after the selection prop is updated.

[getusha]

Looks like a dupe of #10414, we can close it.

[s-alves10]

This is not reproducible on the latest main

[johncschuster]

Thanks for confirming that! I'll go ahead and close it.