-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-17][$500] Move "Troubleshoot" out of About and into Settings as its own nav item #38594
Comments
Triggered auto assignment to @muttmuure ( |
|
Can this be opened to external contributors as this is a relatively simple feature to implement :) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Move "Troubleshoot" out of About and into Settings as its own nav item What is the root cause of that problem?This is the a The App/src/pages/settings/AboutPage/AboutPage.tsx Lines 90 to 94 in 71e3aa4
What changes do you think we should make in order to solve the problem?We need to move it into App/src/pages/settings/InitialSettingsPage.tsx Lines 250 to 256 in 71e3aa4
Also, we need to modify the What alternative solutions did you explore? (Optional)N/A Result :ADDED TEST BRANCH - https://github.com/godofoutcasts94/App/tree/moving-troubleshoot-pageNeed Illustration to be added. |
Updated Proposal |
Upated Proposal, will add updated screenshot in sometime |
I think we should actually make this an External issue, since Tomasz is working on a higher value performance project |
Job added to Upwork: https://www.upwork.com/jobs/~01928d4373947e3fe3 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov ( |
Hey @muttmuure, I have already posted a proposal and I am already working. Should I complete it and post a test branch in the proposal ? |
ProposalPlease re-state the problem that we are trying to solve in this issue.Move "Troubleshoot" out of About and into Settings as its own nav item What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?We need to move the App/src/pages/settings/AboutPage/AboutPage.tsx Lines 90 to 94 in 71e3aa4
To App/src/pages/settings/InitialSettingsPage.tsx Lines 250 to 256 in 71e3aa4
We also need to update the [SCREENS.SETTINGS.ABOUT]: [SCREENS.SETTINGS.APP_DOWNLOAD_LINKS],
[SCREENS.SETTINGS.TROUBLESHOOT]: [SCREENS.SETTINGS.CONSOLE], We must also update the We also need to update The And minor changes to linkingConfig. Test branch : https://github.com/shubham1206agra/App/tree/test-troubleshoot-pag Screenshot What alternative solutions did you explore? (Optional)N/A |
ProposalPlease re-state the problem that we are trying to solve in this issue.What is the root cause of that problem?New feature. What changes do you think we should make in order to solve the problem?Troubleshoot is currently set as RHP. In linkingConfig/config.ts Add this under
And remove it from Add this in BaseCentralPaneNavigator.tsx inside
App/src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator/BaseCentralPaneNavigator.tsx Lines 16 to 23 in 8206580
Remove Add Add Add below in InitialSettingsPage items list
And remove it the troubleshoot option from About page. Example code for the UI (can be polished)
Test branchhttps://github.com/ShridharGoel/ExpensifyApp/tree/test-branch-for-38594 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Move "Troubleshoot" out of About and into Settings as its own nav item What is the root cause of that problem?New feature What changes do you think we should make in order to solve the problem?Steps we need to follow:
Result |
ProposalUpdated with new UI. |
ProposalUpdated with link of test branch |
ProposalPlease re-state the problem that we are trying to solve in this issue.Move TroubleshootPage into the Settings navigation as it's own nav item, and the Troubleshoot UI should look like the About page. What is the root cause of that problem?This is new feature request. What changes do you think we should make in order to solve the problem?Small note for reviewer: I was not the first ones to post the proposal, partly because I tried to actually get it working and implementing it locally first, so that I can write a high quality proposals and able to highlight the differences and caveats that we need to take note of (mostly in the
Some important notes:
It looks completely like design now (except for the light bulb part which I explained above): Here's the full code for the UI part
What alternative solutions did you explore? (Optional)NA |
ProposalUpdated to polish the UI even more. |
Note that I've also added the needed light bulb in |
Since this is feature implementation, I'd be happy to provide the full test branch for my proposal upon request (although you can see the full result attached in the proposal from the start) 👍 |
ProposalUpdated due to people posting complete diff for no reason (which is discouraged), and this is not a good practice. |
Updated Proposal with test branch since in the initial comment it was asked to be assigned to |
@muttmuure This one is ready for payment |
I found another regression with this one: the Troubleshoot page uses white/light text for the status bar text, and thus you can't see the status bar on iOS: @tienifr @alitoshmatov can you have a look at that please? Thanks! |
@shawnborton We will update it to something like below, right? |
Exactly, check every other page in Settings and you will see the expected behavior. |
@alitoshmatov PR #44048 to fix #38594 (comment) can be reviewed |
#44048 PR was merged and now on staging |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-17. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-22. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Regression test is here |
Regression period ends on 17th, pr was merged on 10th |
$500 - @alitoshmatov |
Paid |
We want to take the Troubleshoot page:
And move it into the Settings navigation as it's own nav item, right above the Sign Out option at the bottom. When doing this, the Troubleshoot UI should look like the About page, where we use the card style and a nice header with an illustration + h2:
cc @TMisiukiewicz since I think you originally implemented this? This would just be a follow up to that.
cc @muttmuure @Expensify/design
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @muttmuureThe text was updated successfully, but these errors were encountered: