Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 10414]mWeb - Chat - Device keyboard does not auto appear when editing a message #39263

Open
1 of 6 tasks
kbecciv opened this issue Mar 29, 2024 · 12 comments
Open
1 of 6 tasks

Comments

@kbecciv
Copy link

kbecciv commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4464317
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in to New Expensify
  2. Navigate to any chat
  3. Send a message
  4. Tap and hold the message
  5. Tap on edit comment

Expected Result:

Message should enter edit mode and device keyboard should be displayed

Actual Result:

Message enters edit mode but keyboard does not appear

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431793_1711730273564.Record_2024-03-29-17-31-00.1.mp4

View all open jobs on GitHub

@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 and removed Daily KSv2 labels Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Mar 29, 2024

We think that this bug might be related to #vip-vsb

@tylerkaraszewski
Copy link
Contributor

I cannot reproduce this on safari on ios. I don't have an android device to try it. I'll reach out for assistance.

@thienlnam
Copy link
Contributor

This may be related to live markdown web

@tylerkaraszewski
Copy link
Contributor

@francoisl reproduced this on a real android device.

@BartoszGrajdek
Copy link
Contributor

I'll add a PR in a moment 👀

@thienlnam
Copy link
Contributor

Fix is currently being reviewed by @jayeshmangwani

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Mar 29, 2024
@thienlnam
Copy link
Contributor

Turns out this also happens on production so it's not a blocker - but something we should still fix

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

This issue has not been updated in over 15 days. @tylerkaraszewski, @thienlnam, @jayeshmangwani, @BartoszGrajdek eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@thienlnam thienlnam changed the title mWeb - Chat - Device keyboard does not auto appear when editing a message [HOLD https://github.com/Expensify/App/issues/10414]mWeb - Chat - Device keyboard does not auto appear when editing a message Apr 22, 2024
@thienlnam thienlnam changed the title [HOLD https://github.com/Expensify/App/issues/10414]mWeb - Chat - Device keyboard does not auto appear when editing a message [HOLD 10414]mWeb - Chat - Device keyboard does not auto appear when editing a message Apr 22, 2024
@thienlnam thienlnam removed the Reviewing Has a PR in review label Apr 22, 2024
@thienlnam
Copy link
Contributor

Held on #10414

@melvin-bot melvin-bot bot added the Overdue label May 23, 2024
@jayeshmangwani
Copy link
Contributor

Held on #10414

@melvin-bot melvin-bot bot removed the Overdue label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants