[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HIGH][ESM] Localize System Messages

[trjExpensify]

Following the Localize System Messages section of the Enhance System Messages design doc, make the necessary changes to NewDot to ensure that system messages can be displayed in both English and in Spanish.

CC: @deetergp @dylanexpensify I've moved this issue from E/E here.

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

[melvin-bot]

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[BrtqKr]

Hey, I'm a developer from SWM I'd like to take over this issue

[trjExpensify]

Perfect! Doc has been shared to you for access to the section referenced. 👍

[melvin-bot]

@BrtqKr, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[BrtqKr]

Update for today: I'm somewhere in the middle of that, I'll probably request translations and prepare a PR tomorrow
For now, I've got two questions:

• I'm not sure if I understand where ended up in the discussion regarding the delayed reimbursement part, am I supposed to treat this reason as a param, or is it still during verification?
• I assume that in here it's about this url specifically https://help.expensify.com/articles/expensify-classic/reports/Set-a-random-report-audit-schedule

[BrtqKr]

Update for today:

• I've prepared a draft PR, but until I get more details regarding the messages I won't be able to both test and apply proper types
• Also, there are some things waiting to be resolved - translations and the questions above

[deetergp]

I've asked about your questions:

I'm not sure if I understand where ended up in the discussion regarding the delayed reimbursement part, am I supposed to treat this reason as a param, or is it still during verification?

Here

And

I assume that in here it's about this url specifically https://help.expensify.com/articles/expensify-classic/reports/Set-a-random-report-audit-schedule

Here

[deetergp]

@BrtqKr: @dylanexpensify went ahead and got the translations for you:

English: changed merchant from [X] to [Y]
Spanish: cambió de comerciante de [X] a [Y]

English: changed amount from [X] to [Y]
Spanish: cantidad cambiada de [X] a [Y]

English: changed X from [Y] to [Z]
Spanish: cambió X de [X] a [Y]

English: sent this report to USER_B, as USER_A is on vacation
Spanish: envié este informe a USER_B, ya que USER_A está de vacaciones

English: exported this report to [CSV/Integration/QuickBooks]
Spanish: exportó este informe a [CSV/Integración/QuickBooks]

English: marked this report as manually exported to $destination
Spanish: marcó este informe como exportado manualmente a $destination

English: removed the receipt
Spanish: quitó el recibo

English: added a receipt
Spanish: agregó un recibo

English: processed the payment but it’s delayed by 1-2 more business days
Spanish: procesó el pago pero se retrasó entre 1 y 2 días hábiles más

English: canceled the payment
Spanish: canceló el pago

English: paid $X.XX elsewhere
Spanish: pagó $X.XX en otro lugar

English: paid $X.XX via integration
Spanish: pagó $X.XX mediante integración

English: randomly selected for review
Spanish: seleccionado al azar para revisión

English: invited user B
Spanish: usuario invitado B

English: removed user B
Spanish: usuario eliminado B

English: paid $X.XX
Spanish: pagado $X.XX

English: took control
Spanish: tomó el control

English: unapproved $X.XX
Spanish: no aprobado $X.XX

English: failed to export this report to NetSuite. [Specific error message]
Spanish: No se pudo exportar este informe a NetSuite. [Specific error message]

English: couldn’t process the payment, as the payer doesn’t have sufficient funds
Spanish: no se pudo procesar el pago porque el pagador no tiene fondos suficientes

English: couldn’t process the payment due to a problem with the payer’s bank account
Spanish: no se pudo procesar el pago debido a un problema con la cuenta bancaria del pagador.

English: couldn’t process the payment, as the payer changed bank accounts
Spanish: no se pudo procesar el pago porque el pagador cambió de cuenta bancaria.

[BrtqKr]

Update for today:
I've applied the translation changes. I'm waiting for the messaging part, so I can apply types, test the whole flow, and pass it to the review. Please let me know when it's available 🙏

[BrtqKr]

Update for today:
Haven't touched this ticket - still waiting for the back-end PR, which is close to being merged and deployed.

[melvin-bot]

@deetergp, @BrtqKr, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[deetergp]

The backend PR should be merged sometime today 🤞

[parasharrajat]

Can I get access to doc @deetergp @dylanexpensify?

[parasharrajat]

Thanks that is correct. Could you please remove the message to protect email privacy?

[parasharrajat]

I was C+ on the PR @dylanexpensify. Please assign me.

[dylanexpensify]

Done!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [ESM] Localize system messages #43079

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @BrtqKr does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [ESM] Localize system messages #43079

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @BrtqKr does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[dylanexpensify]

Coming up!

[dylanexpensify]

Payment summary:

• Contributor: @parasharrajat $500

Please request!

[parasharrajat]

Payment requested as per #42923 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat