Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are too many contact methods showing #45336

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 12, 2024 · 13 comments
Closed
1 of 6 tasks

There are too many contact methods showing #45336

m-natarajan opened this issue Jul 12, 2024 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720707891026509

Action Performed:

  1. Open app
  2. Go to settings > profile
  3. Click Contact methods

Expected Result:

Only the added contact methods should appear

Actual Result:

There are many contact emails are appearing

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-11.at.7.54.04.PM.mov

Snip - (4) New Expensify - Google Chrome

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 12, 2024
Copy link

melvin-bot bot commented Jul 12, 2024

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 12, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Julesssss Julesssss added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Jul 12, 2024
@Julesssss
Copy link
Contributor

Removing the blocker labels. This doesn't occur for new/typical users and only shows up for power users like the Expensify and Applause teams:

Screenshot 2024-07-12 at 14 13 18

@shubham1206agra
Copy link
Contributor

Happening to my account too. But I am not in either category.

@Tony-MK

This comment was marked as outdated.

@Tony-MK
Copy link
Contributor

Tony-MK commented Jul 12, 2024

Hey @Julesssss and @shubham1206agra, Are there other specific contact methods that should be shown except if the partner name is expensify.com?

@Julesssss
Copy link
Contributor

Hey @Julesssss and @shubham1206agra, Are there other specific contact methods that should be shown except if the partner name is expensify.com?

Do you mean to replace the domain with Expensify?

@Tony-MK
Copy link
Contributor

Tony-MK commented Jul 12, 2024

Hey @Julesssss and @shubham1206agra, Are there other specific contact methods that should be shown except if the partner name is expensify.com?

Do you mean to replace the domain with Expensify?

Well, @Julesssss, this is an FE problem and some logins are visible.

I would like to know if any other login?.partnerName should be displayed except for the Expensify domain.

However, after testing with other domains I believe the solution works.

Thanks.

@dominictb
Copy link
Contributor

Dupe of #45266

@rayane-djouah
Copy link
Contributor

Happening to my account too

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
@RachCHopkins
Copy link
Contributor

RachCHopkins commented Jul 15, 2024

@Julesssss should we be surfacing the expensify.cash details at all? I can't imagine how it would be useful to show anything that's not an email or phone number.

It is also an issue for real customers, here's my customer Sarah and I'm 100% sure these are all from messaging me:

image

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
@Julesssss
Copy link
Contributor

Closing as dupe of #45266.

Thanks @RachCHopkins,that does sound valid so lets continue to resolve on the above issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants