Contact methods - 'expensify.cash-25ffc67..." is created after logging back into the account

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Logout from any account
2. Log back in
3. Go to account settings > Profile > Contact methods

Expected Result:

Ony added contact methods are displayed in contact methods

Actual Result:

Ony added contact methods are displayed in contact methods

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6538782_1720692944075.Contact_method_Issue.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Ony added contact methods are displayed in contact methods

What is the root cause of that problem?

• In ContactMethodsPage, the loginList data:
  

  App/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

  Lines 135 to 137 in 58e2575

  	loginList: {
  	key: ONYXKEYS.LOGIN_LIST,
  	},

  
  contains the login data which has partnerName: "chat-expensify-com" but we do not need it in this page.

What changes do you think we should make in order to solve the problem?

• We need to create a login list selector, that will remove that type of login data and use it in:
  

  App/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

  Lines 135 to 137 in 58e2575

  	loginList: {
  	key: ONYXKEYS.LOGIN_LIST,
  	},

  
  and the other similar cases.

• The selector function is something like:

selector: (data) => {
            return Object.fromEntries(
                Object.entries(data).filter(
                    ([key, value]) => value.partnerName !== 'chat-expensify-com'
                )
            );
        },

What alternative solutions did you explore? (Optional)

• In the main solution, I am using partnerName !== 'chat-expensify-com' to filter the login data. We can also use partnerID if this prop to filter.

[dominictb]

Proposal updated

[rayane-djouah]

Happening to my account too

[Julesssss]

Hey @RachCHopkins. tagging you here as you pointed out that this is occurring for real customers.

[puneetlath]

Going to raise in Slack to find out what the expected behavior is here.

[puneetlath]

@nkuoch I see you added getting the loginlist in Auth a couple weeks ago here.

It seems like that is most likely the cause of this issue as it seems like Login::getList is including these expensify.cash- logins. So we probably need to either filter them out after getting the results or write a different query that doesn't get these. What do you think?

[melvin-bot]

@nkuoch Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

Looks like the fix for this was merged and deployed. And it looks like it's working correctly. Thanks @nkuoch!