Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending the "Welcome to Expensify" email to new accounts created when invited to a workspace #47080

Closed
6 tasks done
Christinadobrzyn opened this issue Aug 8, 2024 · 20 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: latest
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: No
Email or phone of affected tester (no customers): Test accounts:
c.dobrzyn+8765@gmail.com // c.dobrzyn+9876543@expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/414680
Issue reported by: Christina / Daniel
Slack conversation: https://expensify.slack.com/archives/C041MSTR8J1/p1722536450608919

Action Performed:

  1. As an Admin with a Control workspace on Expensify Classic, sign in to www.expensify.com
  2. Go to Settings > Workspaces > [click the workspace name] > Members > invite
  3. Invite someone who doesn't have an Expensify account already.

Expected Result:

This is a feature request based on the Slack discussion, so we'd like to:

  • Stop sending the "Welcome to Expensify" email to any new account invited to a workspace.

Actual Result:

When you are invited to a workspace an account is created for you and you get two emails right away:

  • The "Welcome to Expensify" email from Concierge that links to the Concierge DM on new.expensify.com. This email causes confusion, because it pushes people into NewDot when their company isn't using that product yet and thus a workspace to submit expenses to doesn't exist, the admins are unfamiliar with the UI the invited member is experiencing etc.

  • The "You've been added to the "X" workspace in Expensify!" email that contains the welcomeNote the admin inviting the member has chosen to include (or the default set). The links in this email have better routing logic already, depending on if the workspace invite was via NewDot or OldDot, and if the workspace is NewDot compatible yet.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image image

View all open jobs on GitHub

@Christinadobrzyn Christinadobrzyn added the Daily KSv2 label Aug 8, 2024
@Christinadobrzyn Christinadobrzyn self-assigned this Aug 8, 2024
@Christinadobrzyn Christinadobrzyn added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Current assignee @Christinadobrzyn is eligible for the Bug assigner, not assigning anyone new.

@Christinadobrzyn Christinadobrzyn added the Hot Pick Ready for an engineer to pick up and run with label Aug 8, 2024
@Christinadobrzyn
Copy link
Contributor Author

Posted in wave-collect to find a volunteer - https://expensify.slack.com/archives/C036QM0SLJK/p1723141430569869

@Christinadobrzyn Christinadobrzyn changed the title Disable "Welcome to Expensify" email Disable "Welcome to Expensify" email for users who are invited to Expensify via a workspace on Classic Aug 8, 2024
@trjExpensify trjExpensify changed the title Disable "Welcome to Expensify" email for users who are invited to Expensify via a workspace on Classic Stop sending the "Welcome to Expensify" email to new accounts created by being invited to a workspace Aug 8, 2024
@trjExpensify trjExpensify added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Current assignee @Christinadobrzyn is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 8, 2024
@trjExpensify trjExpensify added the Internal Requires API changes or must be handled by Expensify staff label Aug 8, 2024
@Christinadobrzyn
Copy link
Contributor Author

looking for a volunteer

@tgolen tgolen self-assigned this Aug 19, 2024
@tgolen
Copy link
Contributor

tgolen commented Aug 19, 2024

I'll have a look at this one.

@tgolen
Copy link
Contributor

tgolen commented Aug 19, 2024

@Christinadobrzyn I've got the code change done for this, but I had a question that I wasn't sure about.

Is this GH about removing the "email" specifically, or is it OK to remove the entire Concierge message?

@tgolen tgolen added the Reviewing Has a PR in review label Aug 19, 2024
@Christinadobrzyn
Copy link
Contributor Author

Thanks for picking this up Tim!

Oh that is a good question. This GH is specific to removing the 'welcome message' email.

Are you referring to this welcome message in NewDot?

image

I think we would want to keep this message since it introduces a NewDot user to Concierge. But would that be a problem to keep?

cc @danielrvidal @trjExpensify

@tgolen
Copy link
Contributor

tgolen commented Aug 19, 2024

OK, it really becomes very difficult to drop the email but keep the report comment, unfortunately. The code that sends the email for all report comments is very far removed from the code that invites someone to a workspace, so it becomes very complex to pass this flag through many different layers of code. My main concern is that we are interrupting a flow that happens normally for 99% of report comments, to do something different for this very specific flow.

Stepping back for a quick sec:

The "Welcome to Expensify" email from Concierge that links to the Concierge DM on new.expensify.com. This email causes confusion, because it pushes people into NewDot when their company isn't using that product yet and thus a workspace to submit expenses to doesn't exist, the admins are unfamiliar with the UI the invited member is experiencing etc.

I think we would want to keep this message since it introduces a NewDot user to Concierge.

Are these two things kind of contradictory? If the user is not going to NewDot at all yet, then it doesn't matter if they have a message from Concierge visible in NewDot. Right?

To be clear, what I am proposing (and isn't too difficult) is:

  • ONLY for the flow when someone is invited into a workspace in OldDot: Remove the email AND the report comment

So, users that are invited to workspaces on NewDot, they would still get both the email and the report comment.

@trjExpensify
Copy link
Contributor

trjExpensify commented Aug 20, 2024 via email

@garrettmknight garrettmknight moved this from HOT PICKS to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Aug 20, 2024
@danielrvidal
Copy link
Contributor

Yea, I think make sense. Let's remove from Conciegre UI as well for anyone being invited from a Classic workspace. As @trjExpensify suggested, I'll work with @jamesdeanexpensify to get the beginningOfChatHistory updated for the concierge UI.

Concierge chat
This is the beginning of your chat with Concierge, Expensify’s real-time support tool.

Feel free to remove it for those users though @tgolen

@jamesdeanexpensify
Copy link
Contributor

Should we go with:

This is your chat with Concierge. Use it for 24/7 product support.

@jamesdeanexpensify
Copy link
Contributor

Or a little more descriptive:

This is your chat with Concierge. Ask questions about Expensify and get 24/7 realtime support.

@tgolen
Copy link
Contributor

tgolen commented Aug 21, 2024

OK, thanks all. I will move forward with just removing the whole message for the OldDot invite flow.

@jamesdeanexpensify
Copy link
Contributor

FYI, I'll actually go with this copy, but let me know if anyone feels strongly otherwise:

This is your chat with Concierge. Ask questions and get 24/7 realtime support.

@trjExpensify trjExpensify moved this from Release 2: Summer 2024 (Aug) to Release 2.5: SuiteWorld (Sept 9th) in [#whatsnext] #wave-collect Aug 26, 2024
@trjExpensify trjExpensify removed the Hot Pick Ready for an engineer to pick up and run with label Aug 26, 2024
@Christinadobrzyn
Copy link
Contributor Author

Nice! The PR is in staging! Thanks for pushing this out the door so quick @tgolen!

@tgolen
Copy link
Contributor

tgolen commented Aug 30, 2024

Weekly Update

Next Steps

  • Nothing, just sit tight and wait for production deploy

ETA

  • Deployed to production today, Aug 30

@tgolen
Copy link
Contributor

tgolen commented Sep 6, 2024

Weekly Update

  • The PR was deployed to production

Next Steps

  • Close this out

@tgolen tgolen closed this as completed Sep 6, 2024
@github-project-automation github-project-automation bot moved this from Release 2.5: SuiteWorld (Sept 9th) to Done in [#whatsnext] #wave-collect Sep 6, 2024
@Christinadobrzyn
Copy link
Contributor Author

Thank you so much for taking this @tgolen!

@danielrvidal I don't think there's any need for an announcement or anything to the team about this? Do you think we should announce something?

@danielrvidal
Copy link
Contributor

You could announce something like this:

Hey team, we should no longer be sending welcome emails from Concierge to new users being invited from workspaces on Classic. This was creating confusion for users who were being sent to NewDot by following the link in the invite email. This hopefully clears up a lot of confusion but let's still be on the look out for users in NewDot that we don't think should be in there!

@Christinadobrzyn
Copy link
Contributor Author

awesome! I posted a follow up in the concierge-development convo

@Christinadobrzyn Christinadobrzyn changed the title Stop sending the "Welcome to Expensify" email to new accounts created by being invited to a workspace Stop sending the "Welcome to Expensify" email to new accounts created when invited to a workspace Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants