[$250] Chat - No unread marker when messages are marked unread

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to chat.
3. Send a few messages.
4. Mark any message as unread.

Expected Result:

There will be unread marker.

Actual Result:

There is no unread marker.
In self DM, when marking messages as unread, LHN report is not bolded.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6571535_1723594600338.20240814_081514.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ccdc0ad6595b0550
• Upwork Job ID: 1823596684825360821
• Last Price Increase: 2024-08-14
• Automatic offers:
• nkdengineer | Contributor | 103518252

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-08-14 05:39:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no unread marker.
In self DM, when marking messages as unread, LHN report is not bolded.

What is the root cause of that problem?

We return early if the report action comes from the current user here. It comes from this PR

App/src/pages/home/report/ReportActionsList.tsx

Lines 225 to 228 in b7f7f1b

	const isFromCurrentUser = accountID === (ReportActionsUtils.isReportPreviewAction(reportAction) ? !reportAction.childLastActorAccountID : reportAction.actorAccountID);
	if (isFromCurrentUser) {
	return false;
	}

In the past, we only checked this condition if messageManuallyMarkedUnread is undefined

What changes do you think we should make in order to solve the problem?

We should bring messageManuallyMarkedUnread back and update the condition to check the unread as we do in the past here

App/src/pages/home/report/ReportActionsList.tsx

Lines 225 to 228 in b7f7f1b

	const isFromCurrentUser = accountID === (ReportActionsUtils.isReportPreviewAction(reportAction) ? !reportAction.childLastActorAccountID : reportAction.actorAccountID);
	if (isFromCurrentUser) {
	return false;
	}

What alternative solutions did you explore? (Optional)

I think we can use unreadMarkerTime as messageManuallyMarkedUnread in the past since the aim of this state is the same as messageManuallyMarkedUnread

App/src/pages/home/report/ReportActionsList.tsx

Lines 207 to 212 in b7f7f1b

	* This should ONLY be updated when the user
	* - switches reports
	* - marks a message as read/unread
	* - reads a new message as it is received
	*/
	const [unreadMarkerTime, setUnreadMarkerTime] = useState(report.lastReadTime ?? '');

[hungvu193]

Reviewing shortly

[hungvu193]

I agree with @nkdengineer proposal. Let's bring
messageManuallyMarkedUnread back.

🎀 👀 🎀

[melvin-bot]

Current assignee @techievivek is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ccdc0ad6595b0550

[melvin-bot]

Current assignee @hungvu193 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

Thanks, will raise a PR soon.

[techievivek]

CPed the changes to staging, and tested it out and the bug is gone.

[iwiznia]

PR #47393 caused regression #47481 (comment)

[melvin-bot]

This issue has not been updated in over 15 days. @hungvu193, @kevinksullivan, @techievivek, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hungvu193]

I think this issue is due for payment @kevinksullivan

[kevinksullivan]

@hungvu193 did we get the regression this caused fixed, though?

[kevinksullivan]

Looping in another BZ for your response as I am going OOO.

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[hungvu193]

@hungvu193 did we get the regression this caused fixed, though?

I think it's fixed, I can't seem to reproduce #47481. I don't think this PR caused that regression.

Screen.Recording.2024-09-13.at.14.22.55.mov

[hungvu193]

little bump @lschurr for the payment summary 😄

[lschurr]

@iwiznia are you able to weigh in here? Your comment indicates that the PR caused a regression, and that GH is still open: #47481 (comment)

[iwiznia]

Applause said:

Issue was found when executing this PR #47393

If it was not that PR, what caused the regression?

[melvin-bot]

@hungvu193, @kevinksullivan, @lschurr, @techievivek, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[nkdengineer]

@iwiznia The current RCA of #47481 comes from #45797 because we don't return early in shouldDisplayNewMarker if we already have a unread marker.

[hungvu193]

@lschurr Can you please post the payment summary here so we can close this one?

[lschurr]

Payment summary:

• Contributor: $250 @nkdengineer (paid in Upwork)
• Reviewer: $250 @hungvu193 (please request in NewDot)

[garrettmknight]

$250 approved for @hungvu193