Remove the blink_input_opacity_to_prevent_scrolling_when_focus hack #18266

cubuspl42 · 2023-05-02T14:25:15Z

...as it shouldn't be needed anymore.

Details

The hack is removed, as after a detailed investigation we found out that it's not really necessary anymore, while it caused harm (flickering).

Fixed Issues

$ #16082
PROPOSAL: #16082 (comment)

Tests

(Web only)

Go to Settings > Workspaces > any workspace > Connect bank account
Click "Connect manually"
Continue till Step 2 (Company information)
Click on each segment of the "Incorporation date" field
Verify there is no flicker effect

Offline tests

QA Steps

See Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

mac-chrome-date-picker.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

...as it shouldn't be needed anymore.

MelvinBot · 2023-05-02T14:25:21Z

@puneetlath @s77rt One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2023-05-02T14:33:02Z

@s77rt @puneetlath

As I mentioned before, tomorrow evening I'm going OOO / offline for a few days. So it would be awesome if we manage to merge this in around 24 hours, assuming nothing unexpected happens. I'm finishing the checklist (especially the videos), but everything is ready for review/testing.

puneetlath

Looks good to me. @s77rt if you're able to go through the checklist today, and everything seems good to you, then I think we should be able to get it merged.

cubuspl42 · 2023-05-02T15:13:53Z

Also, there was a mistake in the list of pages using shouldEnableMaxHeight. WorkspaceInviteMessagePage doesn't use shouldEnableMaxHeight; WorkspaceInvitePage does. It doesn't change much.

s77rt · 2023-05-02T16:31:22Z

web/index.html

+    <!--
+        Note: interactive-widget=resizes-content is ignored on iOS Safari. Working around that has proven to be
+        problematic and causing bugs. At the moment of writing, we don't really need to work around this. If we attempt
+        to do that again, we should do that carefully and minding the potential side effects.
+
+        Some context can be found in https://github.com/Expensify/App/issues/16082
+    -->
    <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1, interactive-widget=resizes-content">


Do we even need interactive-widget=resizes-content here?

I think it's respected on iOS Chrome, if I recall correctly

Yes, but do we even need it? This was also added to prevent auto scroll, and auto scroll is not our enemy 😅 so maybe we should remove that code too

The interactive-widget property doesn't affect auto-scroll. This affects viewport behavior when the virtual keyboard is shown.

https://developer.chrome.com/blog/viewport-resize-behavior/

resizes-content is what we want. It's supported mainly (or only?) by Chrome, but it's present in CSS Viewport Module Level 1 Editor’s Draft, so one day maybe even iOS Safari will support it.

So it's unrelated and there's no need to change it.

Can you please remove the comment then, I don't think we need explain anything here, it may be just confusing

We're removing a hack that was a workaround for the fact that Safari doesn't support that property. So that's why I left a comment. But I'll remove it if you think it's confusing

Hmm, I dunno, I think the comment is fine. This is a file we don't touch much, so I don't mind leaving it there.

@s77rt Done

s77rt · 2023-05-02T16:37:09Z

@cubuspl42 Please make the tests clearer, just mention exactly what should be done (in steps) and remove the no regression tests part.

cubuspl42 · 2023-05-02T16:54:15Z

@s77rt I removed the regression tests (as you asked) and clarified the test which verifies that the flickering is gone. Please let me know if that's what you meant.

s77rt · 2023-05-02T19:50:31Z

@cubuspl42 Please make sure the tests are always in a numbered list. Please update to:

Tests

(Web only)

Go to Settings > Workspaces > any workspace > Connect bank account
Click "Connect manually"
Continue till Step 2 (Company information)
Click on each segment of the "Incorporation date" field
Verify there is no flicker effect

The screenshots/videos are too confusing. Please remove them and just keep the Web one.

cubuspl42 · 2023-05-02T19:53:56Z

@s77rt Done

s77rt · 2023-05-02T19:58:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

s77rt

LGTM! 🚀

cc @puneetlath

MelvinBot · 2023-05-02T20:03:40Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

s77rt · 2023-05-02T20:17:18Z

Thank you @puneetlath & @cubuspl42! That was quick! 🚀

OSBotify · 2023-05-03T00:06:59Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.9-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-09T04:06:55Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Remove the blink_input_opacity_to_prevent_scrolling_when_focus hack

60f8e13

...as it shouldn't be needed anymore.

cubuspl42 requested a review from a team as a code owner May 2, 2023 14:25

melvin-bot bot requested review from puneetlath and s77rt and removed request for a team May 2, 2023 14:25

puneetlath previously approved these changes May 2, 2023

View reviewed changes

s77rt suggested changes May 2, 2023

View reviewed changes

index.html: Remove the comment about interactive-widget

12ee87f

cubuspl42 dismissed puneetlath’s stale review via 12ee87f May 2, 2023 19:43

s77rt approved these changes May 2, 2023

View reviewed changes

puneetlath approved these changes May 2, 2023

View reviewed changes

puneetlath merged commit 8b2fbd4 into Expensify:main May 2, 2023

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

marcaaron mentioned this pull request May 3, 2023

Deploy Checklist: New Expensify 2023-05-02 #18322

Closed

59 tasks

s77rt mentioned this pull request May 5, 2023

[$1000] mWeb - Reimburse expenses - Rate amount flashes #18089

Closed

6 tasks

melvin-bot bot mentioned this pull request May 9, 2023

[HOLD for payment 2023-05-16] [$4000] Web - Inputs are "Flickering" in VBA flow when clicked on #16082

Closed

6 tasks

MelvinBot mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 7.32.0 to 9.0.0 #39794

Closed

50 tasks

melvin-bot bot mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 7.32.0 to 9.0.0 #39795

Closed

bernhardoj mentioned this pull request Oct 30, 2024

[$250] Trackpad gestures for navigation history does not work in Newdot #51704

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the blink_input_opacity_to_prevent_scrolling_when_focus hack #18266

Remove the blink_input_opacity_to_prevent_scrolling_when_focus hack #18266

cubuspl42 commented May 2, 2023 •

edited

Loading

MelvinBot commented May 2, 2023

cubuspl42 commented May 2, 2023

puneetlath left a comment

cubuspl42 commented May 2, 2023

s77rt May 2, 2023

cubuspl42 May 2, 2023

s77rt May 2, 2023

cubuspl42 May 2, 2023

s77rt May 2, 2023

cubuspl42 May 2, 2023

puneetlath May 2, 2023

cubuspl42 May 2, 2023

s77rt commented May 2, 2023

cubuspl42 commented May 2, 2023

s77rt commented May 2, 2023

cubuspl42 commented May 2, 2023

s77rt commented May 2, 2023

s77rt left a comment

MelvinBot commented May 2, 2023

s77rt commented May 2, 2023

OSBotify commented May 3, 2023

OSBotify commented May 9, 2023

Remove the blink_input_opacity_to_prevent_scrolling_when_focus hack #18266

Remove the blink_input_opacity_to_prevent_scrolling_when_focus hack #18266

Conversation

cubuspl42 commented May 2, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented May 2, 2023

cubuspl42 commented May 2, 2023

puneetlath left a comment

Choose a reason for hiding this comment

cubuspl42 commented May 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s77rt commented May 2, 2023

cubuspl42 commented May 2, 2023

s77rt commented May 2, 2023

Tests

cubuspl42 commented May 2, 2023

s77rt commented May 2, 2023

Reviewer Checklist

Screenshots/Videos

s77rt left a comment

Choose a reason for hiding this comment

MelvinBot commented May 2, 2023

s77rt commented May 2, 2023

OSBotify commented May 3, 2023

OSBotify commented May 9, 2023

cubuspl42 commented May 2, 2023 •

edited

Loading