feature: Add validation flow to bank account set up #38726

dukenv0307 · 2024-03-21T04:32:05Z

Details

Fixed Issues

$ #33035
PROPOSAL: #33035 (comment)

Tests

Create an unvalidated account on New Expensify by logging into expensify.com with an account on a public domain
Create a workspace for that account
Navigate to your Workspace >
Select either Connect Online With Plaid or Connect Manually
Verify that: User should see a page with a view to validate their account and receive a notification to validate their bank account.
Pressing the < should take them back to the Connect Bank Account with the two options mentioned in step 4.
Once the user verifies their account they should be able to continue with the standard bank account setup flow

It is expected that at this time the user will be logged out shortly after validating their account through this flow.
Verify that no errors appear in the JS console

Offline tests

QA Steps

Create an unvalidated account on New Expensify by logging into expensify.com with an account on a public domain
Create a workspace for that account
Navigate to your Workspace >
Select either Connect Online With Plaid or Connect Manually
Verify that: User should see a page with a view to validate their account and receive a notification to validate their bank account.
Pressing the < should take them back to the Connect Bank Account with the two options mentioned in step 4.
Once the user verifies their account they should be able to continue with the standard bank account setup flow

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android-mweb-resize.mp4

iOS: Native

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

desktop-resize.mp4

melvin-bot · 2024-05-20T09:19:12Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-05-20T09:23:09Z

@allroundexperts I screenshotted all platforms except Android and iOS.
How can we login with an unvalidated account on iOS and Android?

allroundexperts · 2024-05-23T10:47:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

Screen.Recording.2024-05-23.at.5.15.50.PM.mov

iOS: Native

N/A

iOS: mWeb Safari

Screen.Recording.2024-05-23.at.5.10.01.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-23.at.4.48.45.PM.mov

MacOS: Desktop

Desktop.Recording.mov

allroundexperts · 2024-05-23T11:56:55Z

BUG

On going back after verification, you get logged out automatically.

Screen.Recording.2024-05-23.at.4.54.19.PM.mov

dukenv0307 · 2024-05-27T16:20:28Z

On going back, ReconnectApp API is called with params as null, and then we logout automatically. Do you think we should fix this as a separate issue.

allroundexperts · 2024-05-27T16:21:57Z

This seems connected to me. To make things faster, maybe we can request a bounty increase instead of creating a separate issue.

dukenv0307 · 2024-05-28T09:18:24Z

@allroundexperts It's a backend issue. After we validate the account, if we call any other API, BE returns that the session has expired.

Screen.Recording.2024-05-28.at.16.14.36.mov

Screen.Recording.2024-05-28.at.16.17.14.mov

dukenv0307 · 2024-05-28T09:22:36Z

To fix this issue I think when we validate the default contact method, BE should return a new authToken or not expire the current token of the user cc @NikkiWines

allroundexperts · 2024-05-29T09:33:21Z

@NikkiWines Can you check if this can be fixed from the backend?

NikkiWines · 2024-05-29T16:25:54Z

Yep, I'll take a look today!

allroundexperts

Looks good other than the logout issue which seems to be related to the backend. @NikkiWines is investigating that.

NikkiWines · 2024-05-31T07:46:50Z

Coincidentally, it looks like we have an open PR to resolve this bug as part of a different issue - #35791

@hayata-suenaga do you have an ETA for that PR by any chance?

allroundexperts · 2024-06-01T18:27:32Z

I think we can merge this since the bug is un-related to this PR.

hayata-suenaga · 2024-06-03T14:48:07Z

That PS was in my backlog. Seems like this PR is not related to my PR 😄

dukenv0307 · 2024-06-06T05:03:01Z

I think we can merge this since the bug is un-related to this PR.

@NikkiWines What do you think about this?

NikkiWines · 2024-06-06T05:03:31Z

@hayata-suenaga it is related to your PR (though unbeknownst to you until now) as the functionality you added in https://github.com/Expensify/Web-Expensify/pull/41180 is being utilized as part of this new feature.

However, agreed with @allroundexperts that we can merge this PR as is since the sign-out issue is already known will presumably be fixed with #35791.

NikkiWines

Looks good though clicking on the verify the account link the first time fails to redirect the user appropriately.

After that it works fine though 👍

Screen.Recording.2024-06-05.at.22.19.20.mov

NikkiWines · 2024-06-06T05:17:24Z

src/languages/en.ts

-            phrase2: 'sign back in with a magic code',
+            phrase2: 'sign back in with a magic code ',
+            phrase3: 'or ',
+            phrase4: 'verify the account here',


Let's change this to verify your account here (and also update the Spanish copy accordingly)

@NikkiWines I updated.

NikkiWines

Works great aside from the aforementioned log out issue.

OSBotify · 2024-06-07T01:45:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T23:31:01Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

etCoderDysto · 2024-07-03T14:46:57Z

Hi @dukenv0307, I am working on extracting the component you have built here and use it on 2FA page when user is not validated. I am facing this navigation issue while trying to use the component on CodeStep of 2FA page. For the past few days, I have been trying to investigate the issue to no avail. Could you please help me understand the issue? Thank you!

dukenv0307 added 3 commits March 21, 2024 11:29

feature: Add validation flow to bank account set up

eb4b183

resolve conflict

cac219f

edit translation key

9c6468f

dukenv0307 marked this pull request as ready for review May 20, 2024 09:19

dukenv0307 requested a review from a team as a code owner May 20, 2024 09:19

melvin-bot bot removed the request for review from a team May 20, 2024 09:19

melvin-bot bot requested a review from allroundexperts May 20, 2024 09:19

dukenv0307 mentioned this pull request May 20, 2024

[HOLD for payment 2024-06-20][Unvalidated Sign-Up] [$500] Add validation flow to bank account set up #33035

Closed

6 tasks

Merge branch 'main' into fix/33035

e992ae3

allroundexperts approved these changes May 30, 2024

View reviewed changes

melvin-bot bot requested a review from NikkiWines May 30, 2024 17:22

NikkiWines requested changes Jun 6, 2024

View reviewed changes

dukenv0307 added 2 commits June 6, 2024 14:36

Merge branch 'main' into fix/33035

19d45ed

update translation

392252f

NikkiWines approved these changes Jun 7, 2024

View reviewed changes

NikkiWines merged commit fbd51e4 into Expensify:main Jun 7, 2024
17 checks passed

github-actions bot mentioned this pull request Jun 10, 2024

Deploy Checklist: New Expensify 2024-06-10 #43344

Closed

lanitochka17 mentioned this pull request Jun 10, 2024

[$500] Workspace - Keyboard is flickering when entering magic code at bank account flow #43425

Closed

6 tasks

etCoderDysto mentioned this pull request Jul 31, 2024

[HOLD for payment 2024-08-29] [$250] 2FA - No recovery codes in 2FA page for unverified account #43603

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: Add validation flow to bank account set up #38726

feature: Add validation flow to bank account set up #38726

dukenv0307 commented Mar 21, 2024 •

edited by NikkiWines

Loading

melvin-bot bot commented May 20, 2024

dukenv0307 commented May 20, 2024

allroundexperts commented May 23, 2024 •

edited

Loading

allroundexperts commented May 23, 2024

dukenv0307 commented May 27, 2024

allroundexperts commented May 27, 2024

dukenv0307 commented May 28, 2024

dukenv0307 commented May 28, 2024 •

edited

Loading

allroundexperts commented May 29, 2024

NikkiWines commented May 29, 2024

allroundexperts left a comment

NikkiWines commented May 31, 2024

allroundexperts commented Jun 1, 2024

hayata-suenaga commented Jun 3, 2024

dukenv0307 commented Jun 6, 2024

NikkiWines commented Jun 6, 2024

NikkiWines left a comment

NikkiWines Jun 6, 2024

dukenv0307 Jun 6, 2024

NikkiWines left a comment

OSBotify commented Jun 7, 2024

OSBotify commented Jun 11, 2024

etCoderDysto commented Jul 3, 2024

feature: Add validation flow to bank account set up #38726

feature: Add validation flow to bank account set up #38726

Conversation

dukenv0307 commented Mar 21, 2024 • edited by NikkiWines Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 20, 2024

dukenv0307 commented May 20, 2024

allroundexperts commented May 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented May 23, 2024

dukenv0307 commented May 27, 2024

allroundexperts commented May 27, 2024

dukenv0307 commented May 28, 2024

dukenv0307 commented May 28, 2024 • edited Loading

allroundexperts commented May 29, 2024

NikkiWines commented May 29, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

NikkiWines commented May 31, 2024

allroundexperts commented Jun 1, 2024

hayata-suenaga commented Jun 3, 2024

dukenv0307 commented Jun 6, 2024

NikkiWines commented Jun 6, 2024

NikkiWines left a comment

Choose a reason for hiding this comment

NikkiWines Jun 6, 2024

Choose a reason for hiding this comment

dukenv0307 Jun 6, 2024

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 7, 2024

OSBotify commented Jun 11, 2024

etCoderDysto commented Jul 3, 2024

dukenv0307 commented Mar 21, 2024 •

edited by NikkiWines

Loading

allroundexperts commented May 23, 2024 •

edited

Loading

dukenv0307 commented May 28, 2024 •

edited

Loading