-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncation fix for Lack of maximum height for the description field #38890
Merged
puneetlath
merged 104 commits into
Expensify:main
from
brandonhenry:add-markdown-trunctation-function
Aug 26, 2024
Merged
Changes from all commits
Commits
Show all changes
104 commits
Select commit
Hold shift + click to select a range
b65f652
fix by truncation
brandonhenry 203401a
Move code to expensify-common
brandonhenry 8add74a
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry c2fcf52
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 3a0ce57
Update MenuItem.tsx
brandonhenry b5a0b82
Merge branch 'Expensify:main' into add-markdown-trunctation-function
brandonhenry 698fa7c
Merge branch 'Expensify:main' into add-markdown-trunctation-function
brandonhenry 8c64ad6
add example
brandonhenry e92e301
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry d6df6da
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry f331bb0
fixed truncation
brandonhenry dcd26a0
ran prettier
brandonhenry c2bce3e
added more comments
brandonhenry de55c62
prettier
brandonhenry 2977b28
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 2818795
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 25faab7
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 74dadb1
changed truncate function to html only
brandonhenry 6cf6c14
updated regex, removed redundant code
brandonhenry 8fa8ef3
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 47820fc
Update MenuItem.tsx
brandonhenry 1120be7
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry d9d2551
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 1dd2e6c
Update src/components/MenuItem.tsx
brandonhenry 1755964
Update src/components/MenuItem.tsx
brandonhenry 1543cf9
Update src/components/MenuItem.tsx
brandonhenry 50da8d9
Update src/components/MenuItem.tsx
brandonhenry d12a415
Update src/components/MenuItem.tsx
brandonhenry 8129613
Update src/components/MenuItem.tsx
brandonhenry 5b8b151
reworked naming
brandonhenry f0b7b0d
Update MenuItem.tsx
brandonhenry 3fd5d4e
Update MenuItem.tsx
brandonhenry 1066565
reworked wordbreak section
brandonhenry 5e11266
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 3c1b144
Update src/components/MenuItem.tsx
brandonhenry cd91561
Update src/components/MenuItem.tsx
brandonhenry 7992c53
Update src/components/MenuItem.tsx
brandonhenry 3d7302c
Removed reviewed implementation
brandonhenry 0fb28ca
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 5ed6237
ran prettier
brandonhenry c48a33e
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 0f84e6f
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 9ed9938
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 7c195bf
Update MenuItem.tsx
brandonhenry d50e29a
Update Parser.ts
brandonhenry d6c261e
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 87630b9
updated expensify-common version
brandonhenry 51414c9
revert package change...
brandonhenry fd98fcb
reset package.json to main
brandonhenry 727e764
Update package.json
brandonhenry 9adefcb
Update package.json
brandonhenry daf0185
Update MenuItem.tsx
brandonhenry b4c677a
Update MenuItem.tsx
brandonhenry a2a2f21
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 94fdf0a
Update package.json
brandonhenry 91cb9d1
update expenify common
brandonhenry da86d95
update options
brandonhenry 619d82f
Update MenuItem.tsx
brandonhenry d1a7b9e
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry c35ce60
Update package.json
brandonhenry 69341a3
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 54ffba0
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 7693678
Update MenuItem.tsx
brandonhenry d959a13
Update MenuItem.tsx
brandonhenry c1ce0fe
Update MenuItem.tsx
brandonhenry 2f9b0a2
Update MenuItem.tsx
brandonhenry a76309c
Remove limiting all MenuItems and only limit MenuItemWithDescription
brandonhenry e17968e
added shouldTruncateDescription
brandonhenry 85570da
Update src/components/MenuItem.tsx
brandonhenry 93def06
Update src/components/MenuItem.tsx
brandonhenry 2d1d8ad
Update src/components/MenuItemWithTopDescription.tsx
brandonhenry 32ab203
Update src/components/MenuItem.tsx
brandonhenry a21c00c
update limit to 200
brandonhenry 82d470a
Update src/components/MenuItem.tsx
brandonhenry 2a9ad8d
Update src/components/MenuItem.tsx
brandonhenry 6e9d92c
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry dd3222f
Update MenuItem.tsx
brandonhenry c161d84
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 13bde07
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 998e0fa
Added truncation toggle
brandonhenry c95efb1
Logic adjust
brandonhenry 0c5ccf3
updated report description page
brandonhenry f4aa3f7
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry f292a65
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry ab6323a
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 0524ef2
Update ReportDetailsPage.tsx
brandonhenry abbd948
Update ReportDetailsPage.tsx
brandonhenry 57bab01
updated to add description for those not editing
brandonhenry 40f208d
prettier
brandonhenry db5771a
revert..
brandonhenry 5735fb9
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 22c87da
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 8109827
Update src/pages/RoomDescriptionPage.tsx
brandonhenry 8b64470
Update src/pages/RoomDescriptionPage.tsx
brandonhenry c59ff4f
Update src/pages/RoomDescriptionPage.tsx
brandonhenry 8cba44b
Update src/pages/RoomDescriptionPage.tsx
brandonhenry 6857d0d
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 3ab8cd8
Update RoomDescriptionPage.tsx
brandonhenry 5ce3ef5
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry 77b6b37
Update src/components/MenuItem.tsx
brandonhenry 6e80b27
Update src/components/MenuItem.tsx
brandonhenry bce1cd5
update param name
brandonhenry a30023e
Update MenuItem.tsx
brandonhenry 4eb703b
Merge remote-tracking branch 'upstream/main' into add-markdown-trunct…
brandonhenry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We forgot to wrap the content in
comment
tag, which broke this truncation for plain text. The issue is here