Fetch local currency on each IOU request, to ensure local currency is always up to date #4225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In the original design for Request Money & Split Bills, we were to fetch the user's local currency each time the user started the flow to ensure their local currency was always set correctly. This was once the case, but is no longer occurring.
We also need to ensure the flow can be navigated when the user is offline.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/171917
Tests
A) I ran the QA steps
B) Check the flow is not blocked when the
GetLocalCurrency
request failsGetLocalCurrency
command name in Web-eC) Check the flow is not blocked when offline
QA Steps
View > Developer > Developer Tools
orCMD + OPTION + i
Split Bill
orRequest Money
GetLocalCurrency
&Mobile_GetConstants
)Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android