Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch local currency on each IOU request, to ensure local currency is always up to date #4225

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Jul 26, 2021

Details

In the original design for Request Money & Split Bills, we were to fetch the user's local currency each time the user started the flow to ensure their local currency was always set correctly. This was once the case, but is no longer occurring.

We also need to ensure the flow can be navigated when the user is offline.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/171917

Tests

A) I ran the QA steps

B) Check the flow is not blocked when the GetLocalCurrency request fails

  • I broke the GetLocalCurrency command name in Web-e
  • In E.cash, I opened the IOUModal to make a request
  • Although the request failed, the loading spinner still disappeared, and the flow could be navigated

C) Check the flow is not blocked when offline

  • I switched off WiFi
  • Opened the Request Money flow via the global menu
  • The spinner did NOT block progress, and the previously set currency was used

QA Steps

  • Open the app in Chrome
  • Open developer tools via View > Developer > Developer Tools or CMD + OPTION + i
  • Switch to the Network tab, clear the console
  • From either the global nav, or DM menus, select Split Bill or Request Money
  • You should see 2 Network requests in the Network tab (GetLocalCurrency & Mobile_GetConstants)

Screenshot 2021-07-26 at 15 51 48

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-07-26 at 15 08 21

Mobile Web

Simulator Screen Shot - iPhone 12 - 2021-07-26 at 15 48 01

Desktop

Screenshot 2021-07-26 at 15 07 09

iOS

Simulator Screen Shot - iPhone 12 - 2021-07-26 at 15 48 39

Android

device-2021-07-26-152116

@Julesssss Julesssss self-assigned this Jul 26, 2021
@Julesssss Julesssss marked this pull request as ready for review July 26, 2021 14:49
@Julesssss Julesssss requested a review from a team as a code owner July 26, 2021 14:49
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team July 26, 2021 14:49
@ctkochan22 ctkochan22 merged commit 29e086b into main Jul 26, 2021
@ctkochan22 ctkochan22 deleted the jules-getLocalCurrencyOnIOUOpen branch July 26, 2021 19:42
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants