-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Billable - Billable toggle should have a locked icon in split details view. #43889
fix: Billable - Billable toggle should have a locked icon in split details view. #43889
Conversation
…tails view. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
will add screenshots in few hours, facing issues with android build. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeRecord_2024-06-20-00-43-52.mp4iOS: NativeScreen.Recording.2024-06-20.at.12.31.40.AM.moviOS: mWeb SafariScreen.Recording.2024-06-19.at.11.44.41.PM.movMacOS: Chrome / SafariScreen.Recording.2024-06-19.at.11.12.49.PM.movMacOS: DesktopScreen.Recording.2024-06-20.at.12.58.17.AM.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.1-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀
|
Details
Fixed Issues
$ #43756
PROPOSAL: #43756 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4