Ping ApplauseLeads when PRs get CPed #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
reviewed
Aug 5, 2021
There was a problem hiding this comment.
@thienlnam is it cool if we put this on HOLD until #4274 is merged and tested? It introduces some substantial changes to how this action works, and we're waiting for the next deploy checklist to test it.
|
@roryabraham Sure sure cool with me 👍 |
thienlnam
changed the title
roryabraham
changed the title
|
@thienlnam Taking this off hold now |
|
Files changed: 0 |
|
Ready for review! cc @madmax330 @roryabraham |
roryabraham
previously approved these changes
Aug 19, 2021
.github/actions/markPullRequestsAsDeployed/markPullRequestsAsDeployed.js
Outdated
Show resolved
Hide resolved
roryabraham
approved these changes
Aug 20, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 20, 2021
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Will ping Applause leads when a PR gets cherry picked
Fixed Issues
$ #4212
QA Steps
CP a PR to staging.
Make sure you see the message
The PR title did not include [No QA], so this likely is a CP that requires QA Expensify/applauseleads