[No QA] Empty state modal #45690

koko57 · 2024-07-18T15:57:34Z

Details

Fixed Issues

$ #44306
PROPOSAL: -

Tests

PREREQUISITES: you need to have permissions for workspace card enabled

Go to Workspaces -> Workspace -> Expensify card (enable it in more features if you don't have it enabled)
Click Issue New Card, verify that you're redirected to the Choose Bank Account page
Choose a bank account
On web after choosing bank account you will see that under the RHP the page changes. Dismiss the modal. On mobile you will see Issue New Card flow step 1 - go back with back button - you should be redirected to the Expensify Card page.
Verify that you see a modal, the skeletons and two buttons (Issue card and Settings) above.
Scroll the page - after scrolling down you should see the disclaimer.

Verify that no errors appear in the JS console

Offline tests

QA Steps

n/a

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

padding fix:

iOS: Native

padding fix:

iOS: mWeb Safari

padding fix:

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/d212e7e7-b42a-4d6a-bae0-30092fa18811

padding fix:

MacOS: Desktop

padding fix:

koko57 · 2024-07-18T15:59:51Z

@shawnborton padding fixed:

shawnborton · 2024-07-18T16:36:41Z

Amazing - and just confirming that the modal uses 20px padding for mobile devices?

koko57 · 2024-07-18T17:18:37Z

@shawnborton yep, it now has the same styles as Workspace Empty page. I have some problems with building the app on mobile rn, so I can't make a screenshot. When I fix it I'll add one.

shawnborton · 2024-07-18T18:25:45Z

Wonderful, thanks again!

mountiny · 2024-07-18T23:26:54Z

@koko57 making a build so you can at least test android

@allgandalf @DylanDylann maybe you could test the native too and provide screenshots to unblock this?

github-actions · 2024-07-19T00:08:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/45690/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/45690/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45690/NewExpensify.dmg	https://45690.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

DylanDylann · 2024-07-19T02:35:30Z

I will take over this PR

DylanDylann · 2024-07-19T02:35:56Z

src/components/Icon/Illustrations.ts

@@ -1,3 +1,4 @@
+import EmptyCardState from '@assets/images/emptystate__expensifycard.svg';


Comment to add reviewer

shawnborton · 2024-07-19T06:55:26Z

The screenshots are looking great! Just one small thing here on mobile where I'm seeing a slight green line/border below the top modal image/illustration:

koko57 · 2024-07-19T07:16:38Z

@shawnborton I'm looking into it. Not sure if it is one of the reasons, but in the SVG the screenshot element is subtly overflowing the green background

shawnborton · 2024-07-19T07:22:32Z

Oh good catch on that... here is a new one to try, sorry for all of the different versions of this one. emptystate__expensifycard.svg.zip

DylanDylann · 2024-07-19T08:40:33Z

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann · 2024-07-19T08:40:53Z

@koko57 It failed on native app

koko57 · 2024-07-19T08:53:15Z

@DylanDylann just pushed a fix for that - can you test on Android, please? I'm still having a problem with building for android, I have screenshots for iOS, will add them in a sec

koko57 · 2024-07-19T08:55:33Z

@shawnborton I've added the screenshots for padding fix for other platforms to the Author's Checklist

koko57 · 2024-07-19T08:56:13Z

@mountiny I'm still fighting with Andorid builds, should I open the PR anyway?

DylanDylann · 2024-07-19T08:58:53Z

I will test this PR on Android. Feel free to open this PR

mountiny

Changes look good to me! @DylanDylann let us know when you are done, thanks

DylanDylann · 2024-07-22T07:00:18Z

@koko57 I don't think we should use ScrollView in EmptyCardView Component. We should display the footer in the end of page

Screen.Recording.2024-07-22.at.13.58.35.mov

shawnborton · 2024-07-22T07:02:22Z

I don't think we should use ScrollView in EmptyCardView Component. We should display the footer in the end of page

What we're doing in the video is on purpose though, we want to make the fine print show below the fold here.

DylanDylann · 2024-07-22T07:10:54Z

@koko57 Please resolve conflict

DylanDylann · 2024-07-22T07:27:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-22.at.14.38.30.mov

Android: mWeb Chrome

Screen.Recording.2024-07-22.at.14.33.20.mov

iOS: Native

Screen.Recording.2024-07-22.at.14.38.04.mov

iOS: mWeb Safari

Screen.Recording.2024-07-22.at.14.31.41.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-22.at.14.27.46.mov

MacOS: Desktop

Screen.Recording.2024-07-22.at.14.30.58.mov

koko57 · 2024-07-22T07:34:33Z

@DylanDylann conflicts resolved

DylanDylann · 2024-07-22T07:43:21Z

@koko57 Lint error 😄

koko57 · 2024-07-22T10:01:34Z

@DylanDylann fixed

mountiny

Thanks, changes looking good, just waiting for a final design confirmation @shawnborton

shawnborton · 2024-07-22T14:51:29Z

Looks good to me! The only minor thing I can spot - do we want a little more space below the buttons and above the empty state rows?

cc @Expensify/design for thoughts

dannymcclain · 2024-07-22T15:50:03Z

Yeah I think the desktop spacing looks pretty good but I think the mobile/small viewports could benefit from a little extra space below the buttons. Not a HUGE deal, but a nice little polish.

mountiny · 2024-07-22T16:24:13Z

Thanks, I think we can address that in the next design follow up as this is a larger PR to avoid conflicts, I will merge it now and link this to the design polish issue

OSBotify · 2024-07-22T16:35:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-23T08:36:53Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-24T00:17:11Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.0.11-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-25T03:17:21Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-26T05:14:55Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

DylanDylann · 2024-08-09T04:18:10Z

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx

-                renderItem={renderItem}
-                ListHeaderComponent={WorkspaceCardListHeader}
-            />
+            {!isEmptyObject(cardsList) ? (


@koko57 Please help to explain this line

As I understand, we display EmptyCardView if cardList í empty

@DylanDylann yes, I did it probably bc I didn't want to remove mockedCard list in this PR. I'll tell Vicky (she's integrating BE with the cardList), to correct this condition

yes, she did it in her PR https://github.com/Expensify/App/pull/47064/files

koko57 added 4 commits July 18, 2024 09:07

feat: create base components

ca2b8a7

feat: insert a proper illustartion, fix skeleton appearance

7f994b7

fix: add disclaimer on scroll

969da50

fix: minor fix

9e2d46d

koko57 added 2 commits July 18, 2024 18:29

fix: minor fixes

f643792

fix: lint

6de8bcc

mountiny assigned koko57 Jul 18, 2024

mountiny self-requested a review July 18, 2024 23:24

mountiny added the Ready To Build label Jul 18, 2024

mountiny mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-08-07] [Workspace Feeds] Design adjustments part 1 #45733

Closed

DylanDylann reviewed Jul 19, 2024

View reviewed changes

Merge branch 'main' into feat/44306-empty-state-modal

121dd3f

fix: fix svg problem on native

237ff7f

koko57 marked this pull request as ready for review July 19, 2024 09:00

mountiny previously approved these changes Jul 19, 2024

View reviewed changes

fix: resolve conflicts

c09a679

koko57 dismissed mountiny’s stale review via c09a679 July 22, 2024 07:34

DylanDylann approved these changes Jul 22, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny July 22, 2024 07:39

koko57 added 2 commits July 22, 2024 09:45

fix: lint

7f372bd

fix: lint

8c91902

mountiny approved these changes Jul 22, 2024

View reviewed changes

MariaHCD approved these changes Jul 22, 2024

View reviewed changes

mountiny merged commit 146b847 into Expensify:main Jul 22, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 23, 2024

Deploy Checklist: New Expensify 2024-07-23 #45991

Closed

95 tasks

melvin-bot bot mentioned this pull request Jul 25, 2024

[HOLD for payment 2024-08-01] [Workspace Feeds] [External] Create a modal for Expensify Card Enabled empty state #44306

Closed

etCoderDysto mentioned this pull request Jul 30, 2024

[HOLD for payment 2024-08-14] [$250] iOS - Expensify Card - Content on Expensify Card intro screen is truncated #45901

Closed

6 tasks

DylanDylann reviewed Aug 9, 2024

View reviewed changes

DylanDylann mentioned this pull request Aug 9, 2024

Fix/46488 fix modal centering #46860

Merged

61 tasks

		@@ -1,3 +1,4 @@
		import EmptyCardState from '@assets/images/emptystate__expensifycard.svg';

[No QA] Empty state modal #45690

[No QA] Empty state modal #45690

Conversation

koko57 commented Jul 18, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

koko57 commented Jul 18, 2024

shawnborton commented Jul 18, 2024

koko57 commented Jul 18, 2024

shawnborton commented Jul 18, 2024

mountiny commented Jul 18, 2024

github-actions bot commented Jul 19, 2024

DylanDylann commented Jul 19, 2024

DylanDylann Jul 19, 2024

Choose a reason for hiding this comment

shawnborton commented Jul 19, 2024

koko57 commented Jul 19, 2024

shawnborton commented Jul 19, 2024

DylanDylann commented Jul 19, 2024

Screenshots/Videos

DylanDylann commented Jul 19, 2024

koko57 commented Jul 19, 2024

koko57 commented Jul 19, 2024

koko57 commented Jul 19, 2024

DylanDylann commented Jul 19, 2024

mountiny left a comment

Choose a reason for hiding this comment

DylanDylann commented Jul 22, 2024

shawnborton commented Jul 22, 2024

DylanDylann commented Jul 22, 2024

DylanDylann commented Jul 22, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

koko57 commented Jul 22, 2024

DylanDylann commented Jul 22, 2024

koko57 commented Jul 22, 2024

mountiny left a comment

Choose a reason for hiding this comment

shawnborton commented Jul 22, 2024

dannymcclain commented Jul 22, 2024

mountiny commented Jul 22, 2024

OSBotify commented Jul 22, 2024

OSBotify commented Jul 23, 2024

OSBotify commented Jul 24, 2024

OSBotify commented Jul 25, 2024

OSBotify commented Jul 26, 2024

DylanDylann Aug 9, 2024

Choose a reason for hiding this comment

koko57 Aug 9, 2024 • edited Loading

Choose a reason for hiding this comment

koko57 Aug 9, 2024

Choose a reason for hiding this comment

koko57 commented Jul 18, 2024 •

edited

Loading

DylanDylann commented Jul 22, 2024 •

edited

Loading

koko57 Aug 9, 2024 •

edited

Loading