Updated propType for Avatar containerStyles in Workspace #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beamanator
approved these changes
Aug 12, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 12, 2021
|
🚀 Deployed to staging by @Beamanator in version: 1.0.85-10 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
|
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Beamanator can you review this?
Details
Updated
propTypefor AvatarcontainerStylesFixed Issues
$ #4489
Tests
This error gets generated on the browser console/terminal.
QA Steps
Not sure if QA would be required here. But to verify the change, all we need to do is ensure that No exception is thrown when Avatar image is updated in workspace.
Tested On
Screenshots
Web
invalid-props-error-web.mp4
Mobile Web
invalid-props-error-mweb.mp4
Desktop
invalid-props-error-desktop.mp4
iOS
invalid-props-error-ios.mp4
Android
invalid-props-error-android.mp4