Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update copy for login #4644

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Conversation

aman-atg
Copy link
Contributor

cc: @MonilBhavsar

Details

#4111 (comment)
#4111 (comment)

Fixed Issues

$ #4111

Tests || QA Steps

  1. Go to newDot
  2. Enter your email/phone : {login}
  3. Press "Continue"
  4. You will see Not {login}? Go back. below the button.
    • Go back. Will be on the next line if the {login} is too long
  5. You will see "We've sent a magic sign in link to your email/phone number." above the button if you don't have an account already.

Tested On

  • Web
  • Mobile Web
  • Android
  • Please test on these two
  • Desktop
  • iOS

Screenshots

Web

prWeb.mp4

Mobile Web

mWeb.mp4

Desktop

iOS

Android

M.mp4

Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-atg sorry for the delayed review here. One minor comment otherwise looks great + works well

src/pages/signin/ResendValidationForm.js Show resolved Hide resolved
@aman-atg
Copy link
Contributor Author

@NikkiWines, PR updated!

@aman-atg
Copy link
Contributor Author

Bump @NikkiWines

Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikkiWines NikkiWines merged commit 234b35f into Expensify:main Aug 23, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

@aman-atg aman-atg deleted the aman-atg-updateLoginMessages branch September 3, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants