Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Use props not state in NewPasswordForm #4684

Merged
merged 1 commit into from
Aug 17, 2021
Merged

[CP Staging] Use props not state in NewPasswordForm #4684

merged 1 commit into from
Aug 17, 2021

Conversation

marcaaron
Copy link
Contributor

Details

cc @stitesExpensify

Fixed Issues

$ #4599

Tests

QA Steps

  1. Create a new account in NewDot
  2. Check the email for the set password link
  3. Tap and try set the password
  4. Verify you are logged in

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner August 17, 2021 03:02
@marcaaron marcaaron self-assigned this Aug 17, 2021
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team August 17, 2021 03:03
@marcaaron marcaaron merged commit 9da26a4 into main Aug 17, 2021
@marcaaron marcaaron deleted the marcaaron-fixSetPasswordPage branch August 17, 2021 04:13
github-actions bot pushed a commit that referenced this pull request Aug 17, 2021
@marcaaron
Merge pull request #4684 from Expensify/marcaaron-fixSetPasswordPage
29924ea 
[CP Staging] Use props not state in NewPasswordForm

(cherry picked from commit 9da26a4)
This was referenced Aug 17, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @marcaaron in version: 1.0.85-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 25, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

This was referenced Sep 1, 2021
Closed
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stitesExpensify stitesExpensify stitesExpensify approved these changes

@johnmlee101 johnmlee101 Awaiting requested review from johnmlee101

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @stitesExpensify