Added translations for CompanyStep #4765
Conversation
|
@iwiznia PR raised. I also found one more problem due to which the form wasn't loading in Android. I've fixed that too. Please validate this commit too. |
src/languages/es.js
Outdated
| @@ -517,6 +517,9 @@ export default { | |||
| listOfRestrictedBusinesses: 'lista de negocios restringidos', | |||
| incorporationDatePlaceholder: 'Fecha de inicio (aaaa-mm-dd)', | |||
| companyPhonePlaceholder: '10 dígitos, sin guiones', | |||
| confirmModalTitle: '¿Está seguro?', | |||
There was a problem hiding this comment.
| confirmModalTitle: '¿Está seguro?', | |
| confirmModalTitle: '¿Estás seguro?', |
There was a problem hiding this comment.
These changes are because we use the informal tu instead of the formal usted
There was a problem hiding this comment.
Changed. Thanks for informing.
src/languages/es.js
Outdated
| @@ -517,6 +517,9 @@ export default { | |||
| listOfRestrictedBusinesses: 'lista de negocios restringidos', | |||
| incorporationDatePlaceholder: 'Fecha de inicio (aaaa-mm-dd)', | |||
| companyPhonePlaceholder: '10 dígitos, sin guiones', | |||
| confirmModalTitle: '¿Está seguro?', | |||
| confirmModalPrompt: 'Por favor, compruebe los campos resaltados e inténtelo de nuevo.', | |||
There was a problem hiding this comment.
| confirmModalPrompt: 'Por favor, compruebe los campos resaltados e inténtelo de nuevo.', | |
| confirmModalPrompt: 'Por favor, comprueba los campos resaltados e inténtalo de nuevo.', |
| @@ -303,7 +303,7 @@ class CompanyStep extends React.Component { | |||
| : ''} | |||
| /> | |||
| <ExpensiTextInput | |||
| autoCompleteType="new-password" | |||
| autoCompleteType="password" | |||
There was a problem hiding this comment.
So this fixes android? What is new-password and password and what's the difference between them?
There was a problem hiding this comment.
For TextInput in Android, the autoCompleteType has to be one of the values listed in this link:
https://reactnative.dev/docs/textinput#autocompletetype-android
If you see password exists to denote the password field. It isn't an id/name field where we can put new-password
src/languages/es.js
Outdated
| @@ -517,6 +517,9 @@ export default { | |||
| listOfRestrictedBusinesses: 'lista de negocios restringidos', | |||
| incorporationDatePlaceholder: 'Fecha de inicio (aaaa-mm-dd)', | |||
| companyPhonePlaceholder: '10 dígitos, sin guiones', | |||
| confirmModalTitle: '¿Está seguro?', | |||
| confirmModalPrompt: 'Por favor, compruebe los campos resaltados e inténtelo de nuevo.', | |||
| confirmModalConfirmText: 'Lo tengo', | |||
There was a problem hiding this comment.
This is a literal translation, but this is not used in spanish, let's use:
| confirmModalConfirmText: 'Lo tengo', | |
| confirmModalConfirmText: 'OK', |
…i/App into translation-companystep # Conflicts: # src/languages/es.js
|
@iwiznia PR updated |
|
@iwiznia thanks for approving. Any other changes pending to be merged? |
|
No no, was waiting for the tests to finish. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Thank you |
|
@akshayasalvi Hello! Any QA tests needed for this PR? |
|
I think @akshayasalvi edited the description to include them already. |
|
Okay. I'll somehow missed putting a comment for this one. Thank you. |
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
Details
Added missing translations for CompanyStep modal.
Fixed Issues
$ #4744
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android