Fix MarkerBadge Count #4773
Fix MarkerBadge Count #4773
Conversation
parasharrajat
force-pushed
the
markercount
branch
from
cb47501
to
cdb30cc
Compare
| @@ -99,6 +99,7 @@ class ReportActionsView extends React.Component { | |||
| this.state = { | |||
| isLoadingMoreChats: false, | |||
| isMarkerActive: false, | |||
| unreadActionCount: this.props.report.unreadActionCount, | |||
There was a problem hiding this comment.
I don't think it's great that this state variable shadows the name of the prop. Instead, we should call it localUnreadActionCount or something. And then updateUnreadMessageCount would be updateLocalUnreadActionCount
| @@ -199,8 +205,16 @@ class ReportActionsView extends React.Component { | |||
| updateLastReadActionID(this.props.reportID); | |||
| } | |||
|
|
|||
| // show new MarkerBadge when there is a new Message | |||
| this.toggleMarker(); | |||
| if (lastAction && (lastAction.actorEmail !== this.props.session.email)) { | |||
There was a problem hiding this comment.
Maybe should use lodashGet for both of these since session can technically be {}:
| if (lastAction && (lastAction.actorEmail !== this.props.session.email)) { | |
| if (lodashGet(lastAction, actorEmail, '') !== lodashGet(this.props.session, 'email', '')) { |
|
Updated |
|
@roryabraham I think this is ready to roll. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
This was deployed to staging |
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
Details
Fixed Issues
$ #4669
Tests QA Steps
Tested On
Screenshots
Web | Desktop | Mobile Web
count-marker.mp4
iOS
Android