-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set default badge when only one defaultable payment method is available #7767
Conversation
Note: This might be difficult to test until the deploy blocker mentioned here is resolved. I did the test steps on production and then checked the local PR against the production data to verify things work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should we |
Yeah, let's do that. Thanks! This will fail QA if we try to test it now. |
Took this one off hold and merging |
Triggered auto assignment to @marcochavezf ( |
@marcaaron looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Not an emergency. The label seems to have been applied in error as all tests were passing. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcaaron in version: 1.1.41-0 🚀
|
Tested this on staging and it works as intended. However, when we add a debit card we get a weird error:
Not a blocker, but I'll create an issue. |
🚀 Deployed to staging by @marcaaron in version: 1.1.41-0 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀
|
Details
Fixed Issues
$ #7613
Tests
QA Steps (Internal)
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android