Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make push notifications navigate to the correct chat - iOS" #7939

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Revert "Make push notifications navigate to the correct chat - iOS" #7939

merged 1 commit into from
Feb 28, 2022

Conversation

roryabraham
Copy link
Contributor

Reverts #7633

@roryabraham roryabraham requested a review from a team as a code owner February 28, 2022 20:33
@roryabraham roryabraham self-assigned this Feb 28, 2022
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from madmax330 and removed request for a team February 28, 2022 20:33
@roryabraham roryabraham merged commit ffc82b0 into main Feb 28, 2022
@roryabraham roryabraham deleted the revert-7633-neil-ios-notifications-link branch February 28, 2022 23:57
OSBotify pushed a commit that referenced this pull request Mar 1, 2022
@roryabraham @OSBotify
Merge pull request #7939 from Expensify/revert-7633-neil-ios-notifica…
6b4f5c8 
…tions-link

(cherry picked from commit ffc82b0)
This was referenced Mar 1, 2022
Merged
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.40-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Mar 2, 2022
Closed
68 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisl francoisl francoisl approved these changes

@madmax330 madmax330 Awaiting requested review from madmax330

@sketchydroide sketchydroide Awaiting requested review from sketchydroide

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @francoisl