[NewDot API] Create new API.js #9171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkuoch
force-pushed
the
nat-api
branch
4 times, most recently
from
b5b913d
to
95fc7de
Compare
melvin-bot
bot
requested review from
tylerkaraszewski
and removed request for
a team
marcaaron
approved these changes
May 30, 2022
| @@ -39,7 +39,9 @@ function Reauthentication(response, request, isFromSequentialQueue) { | |||
| return data; | |||
| } | |||
|
|
|||
| request.resolve(data); | |||
| if (request.resolve) { | |||
There was a problem hiding this comment.
NAB, might want to add a comment (or create an issue to clean up later) as this code (and other things in /Network referencing request.resolve) can be removed once we are fully migrated off of the DeprecatedAPI.
There was a problem hiding this comment.
6 tasks
|
🚀 Deployed to production by @luacmartins in version: 1.1.70-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @marcaaron and @yuwenmemon
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/211230
Tests
Tested in #9220