Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use a handle from the existing pool instead of a new one" #1553

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

coleaeason
Copy link
Contributor

Reverts #1551

This is broken when used with Auth, I'll try to figure out a fix, but for now let's just revert so we can deploy. The old code worked fine.

@coleaeason coleaeason self-assigned this Jul 31, 2023
@johnmlee101 johnmlee101 merged commit 1df0027 into main Jul 31, 2023
1 of 2 checks passed
@johnmlee101 johnmlee101 deleted the revert-1551-cole_use_pool branch July 31, 2023 23:11
@melvin-bot melvin-bot bot added the Emergency Marks a change in which we bypassed our normal process (eg, skipped travis) label Jul 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 31, 2023

@johnmlee101 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@johnmlee101 johnmlee101 removed the Emergency Marks a change in which we bypassed our normal process (eg, skipped travis) label Jul 31, 2023
@johnmlee101
Copy link
Contributor

Straight revert, merged without tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants