Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/skip_invalid_credentials #158

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

Kondrahin
Copy link
Contributor

@Kondrahin Kondrahin commented Aug 17, 2021

Description

Botx now skipping invalid credentials

P.S. *args in authorize are needed in order to use this method in bot.startup_events. See PR in Box after this were merged.

Checklist

  • Linters and tests have passed
  • I've written a changelog for PR change
  • I'll make a release when PR is approved

@github-actions
Copy link

github-actions bot commented Aug 17, 2021

@github-actions github-actions bot temporarily deployed to pull request August 17, 2021 14:10 Inactive
@Kondrahin Kondrahin force-pushed the feature/skip_invalid_credentials branch from f8c43b9 to b632011 Compare August 17, 2021 14:11
@github-actions github-actions bot temporarily deployed to pull request August 17, 2021 14:12 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #158 (d0962d6) into master (036a844) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          251       251           
  Lines         5671      5681   +10     
  Branches       225       225           
=========================================
+ Hits          5671      5681   +10     
Impacted Files Coverage Δ
botx/bots/bots.py 100.00% <100.00%> (ø)
tests/test_models/test_credentials.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 036a844...d0962d6. Read the comment docs.

@Kondrahin Kondrahin force-pushed the feature/skip_invalid_credentials branch from b632011 to 990b9f9 Compare August 17, 2021 14:49
@github-actions github-actions bot temporarily deployed to pull request August 17, 2021 14:49 Inactive
botx/bots/bots.py Outdated Show resolved Hide resolved
docs/changelog.md Outdated Show resolved Hide resolved
botx/bots/bots.py Show resolved Hide resolved
@Kondrahin Kondrahin force-pushed the feature/skip_invalid_credentials branch from 990b9f9 to ebf0f4b Compare August 18, 2021 08:10
@github-actions github-actions bot temporarily deployed to pull request August 18, 2021 08:11 Inactive
@Kondrahin Kondrahin force-pushed the feature/skip_invalid_credentials branch from ebf0f4b to d0962d6 Compare August 18, 2021 08:15
@github-actions github-actions bot temporarily deployed to pull request August 18, 2021 08:16 Inactive
@Kondrahin Kondrahin requested a review from Opti213 August 19, 2021 09:46
@Kondrahin Kondrahin merged commit 832c257 into master Aug 23, 2021
@Kondrahin Kondrahin deleted the feature/skip_invalid_credentials branch August 23, 2021 06:45
Kondrahin added a commit that referenced this pull request Aug 30, 2021
Opti213 pushed a commit that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants