Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name param to download_file method #167

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

rrrrs09
Copy link
Contributor

@rrrrs09 rrrrs09 commented Sep 9, 2021

Description

Added file_name param to download_file method to provide ability to change returned file name

Checklist

  • Linters and tests have passed
  • I've written a changelog for PR change
  • I'll make a release when PR is approved

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #167 (cd2906d) into master (be2f496) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          275       275           
  Lines         6177      6184    +7     
  Branches       231       232    +1     
=========================================
+ Hits          6177      6184    +7     
Impacted Files Coverage Δ
botx/bots/mixins/requests/files.py 100.00% <100.00%> (ø)
.../test_bots/test_mixins/test_requests/test_files.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2f496...cd2906d. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

@github-actions github-actions bot temporarily deployed to pull request September 9, 2021 07:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 9, 2021 07:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 9, 2021 09:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 9, 2021 09:25 Inactive
@rrrrs09 rrrrs09 merged commit 4d0d827 into master Sep 9, 2021
@rrrrs09 rrrrs09 deleted the feature/add-name-param branch September 9, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants