Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default button center align #403

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

depostnykh
Copy link
Contributor

@depostnykh depostnykh commented Jun 21, 2023

Task BOTS-6396:

  • add default center align to dataclass Button and BaseMarkup.add_button;
  • fix tests;

PR checklist

  • I've written good commit message for all commits
  • I've split changes into separate commits where it's appropriate
  • I've added the description of function to documentation
  • I've updated project version in pyproject.toml
  • I'll make a release when PR is merged
  • I'll bump pybotx in bot-template

Task BOTS-6396:
- add default center align to dataclass Button and BaseMarkup.add_button;
- fix tests;
@siderai
Copy link
Contributor

siderai commented Jun 21, 2023

нужно прогнать форматтер и линтер
запускается командой ./scripts/format из директории проекта

также надо поднять версию библиотеки до 0.55.6 в pyproject.toml

Task BOTS-6396:
- fix code format in tests;
- change pybotx version in pyproject.toml;
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dc234fb) 100.00% compared to head (b2caf68) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #403   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         3673      3673           
  Branches       321       321           
=========================================
  Hits          3673      3673           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pybotx/models/message/markup.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@depostnykh
Copy link
Contributor Author

нужно прогнать форматтер и линтер запускается командой ./scripts/format из директории проекта - выполнено.
также надо поднять версию библиотеки до 0.55.6 в pyproject.toml - выполнено.

@alexhook
Copy link
Member

0.55.7 ставьте, у меня MR на 0.55.6

@depostnykh depostnykh merged commit 56c9999 into master Jun 22, 2023
@depostnykh depostnykh deleted the feat/dp/default-button-center-align branch June 22, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants