Remove promisify shim

ExpressGateway · Sep 26, 2018 · c1ecab0 · c1ecab0
1 parent 2da2073
commit c1ecab0
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 39 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -5,7 +5,15 @@ jobs:
       - image: circleci/node:8-browsers
     working_directory: ~/repo
 
-    steps: *eg-checkout-install
+    steps: &eg-checkout-install
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ checksum "package.json" }}
+      - run: npm ci
+      - save_cache:
+          key: dependency-cache-{{ checksum "package.json" }}
+          paths:
+            - ./node_modules
 
   "node-10":
     docker:

diff --git a/.eslintrc b/.eslintrc
@@ -34,14 +34,6 @@
           "crypto.createDecipher"
         ]
       }
-    ],
-    "node/no-unsupported-features/node-builtins": [
-      "error",
-      {
-        "ignores": [
-          "util.promisify"
-        ]
-      }
     ]
   },
   "root": true

diff --git a/bin/index.js b/bin/index.js
@@ -1,7 +1,5 @@
 #!/usr/bin/env node
 
-require('util.promisify/shim')(); // NOTE: shim for native node 8.0 uril.promisify
-
 const eg = {
   get config () {
     return require('../lib/config');

diff --git a/lib/config/config.js b/lib/config/config.js
@@ -1,4 +1,3 @@
-require('util.promisify/shim')();
 const fs = require('fs');
 const util = require('util');
 const readFile = util.promisify(fs.readFile);

diff --git a/lib/index.js b/lib/index.js
@@ -1,5 +1,5 @@
 require('./eventBus'); // init event bus
-require('util.promisify/shim')(); // NOTE: shim for native node 8.0 uril.promisify
+
 const pluginsLoader = require('./plugins');
 if (require.main === module) {
   const config = require('./config'); // this is to init config before loading servers and plugins

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -28,7 +28,7 @@
   "license": "Apache-2.0",
   "main": "lib/index.js",
   "engines": {
-    "node": ">= 6.0.0"
+    "node": ">= 8.0.0"
   },
   "scripts": {
     "start": "node lib/index.js",
@@ -97,7 +97,6 @@
     "superagent-logger": "^1.1.0",
     "superagent-prefix": "0.0.2",
     "swagger-ui-express": "^3.0.10",
-    "util.promisify": "^1.0.0",
     "uuid": "^3.3.2",
     "uuid62": "^1.0.0",
     "vhost": "3.0.2",