Authenticating consumer no longer requires options to be passed, all… #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owing authenticateToken to work correctly
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 213 213
Lines 9174 9174
=======================================
Hits 8381 8381
Misses 793 793
Continue to review full report at Codecov.
|
XVincentX
reviewed
Oct 8, 2017
lib/services/auth.js
Outdated
| @@ -106,6 +106,7 @@ s.authorizeCredential = function (id, authType, scopes) { | |||
| }; | |||
|
|
|||
| s.validateConsumer = function (id, options) { | |||
| options = options || {}; | |||
There was a problem hiding this comment.
I think you can probably do function(id, options = {})
There was a problem hiding this comment.
Good point. Need to remember this! Shall update now and push.
gatherchou
pushed a commit
to yilu-tech/express-gateway
that referenced
this pull request
Jul 29, 2021
…ons_default Authenticating consumer no longer requires options to be passed, all…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, authenticateToken() did not work when needing to validate consumer due to not passing options.
As options are not required, don't make them required.