Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collage: ZeroConf support and node discovery #122

Closed
eile opened this issue May 24, 2012 · 3 comments
Closed

Collage: ZeroConf support and node discovery #122

eile opened this issue May 24, 2012 · 3 comments
Assignees
Labels
Milestone

Comments

@eile
Copy link
Member

eile commented May 24, 2012

Requested by @tribal-tec: Announce node id and connection parameters using servus/ZeroConf, and use this information in LocalNode::connect(id). Expose the servus::Service so applications can add their one key/value pairs for additional information.

@ghost ghost assigned eile May 24, 2012
@eile
Copy link
Member Author

eile commented May 24, 2012

Issue 1: Expose Service or only add set( key, value ) method to LocalNode?
Resolved: Use API as defined below.

Internally we'll use the service to discover() other nodes during connect(). Exposing the full Service risks races if the application does the same thing.

Adding only a set() method limits functionality. It allows to have a stable API, the set() without servus would be an empty implementation.

@eile
Copy link
Member Author

eile commented May 24, 2012

Service name will be '_collage._tcp'

eile added a commit that referenced this issue May 24, 2012
@eile
Copy link
Member Author

eile commented May 24, 2012

API:

Zeroconf co::LocalNode::getZeroconf();
class Zeroconf
{
    // has a servus::Service and copy of discovered data
   void set( const::std::string& key, const std::string& value );
   Strings getHosts() const;
   Strings getKeys( const std::string& host ) const;
   bool containsKey( const std::string& host, const std::string& key ) const;
   const std::string& get( const std::string& host, const std::string& key ) const;
};    

eile added a commit that referenced this issue May 24, 2012
eile added a commit that referenced this issue May 24, 2012
eile added a commit to Eyescale/Lunchbox that referenced this issue May 24, 2012
eile added a commit that referenced this issue May 24, 2012
eile added a commit to Eyescale/Lunchbox that referenced this issue May 24, 2012
@eile eile closed this as completed in 2b9c28f May 29, 2012
eile added a commit that referenced this issue May 29, 2012
eile added a commit that referenced this issue May 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant