Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Deflect streaming activation, according to BlueBrain/Deflect#98 #561

Merged
merged 2 commits into from
Jun 7, 2016

Conversation

tribal-tec
Copy link
Member

No description provided.

@@ -50,14 +50,12 @@ class Proxy::Impl : public boost::noncopyable
{
public:
explicit Impl( Channel* channel )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass Channel& ?

@eile
Copy link
Member

eile commented Jun 6, 2016

+1 otherwise

@rdumusc
Copy link

rdumusc commented Jun 6, 2016

Missing .gitsubprojects update
+1 otherwise, and thanks for the quick adaptation!

@tribal-tec
Copy link
Member Author

Good catches in the review. Thanks!

@tribal-tec
Copy link
Member Author

Updated. I also added Deflect event support if the Qt window system is used.

@eile eile merged commit 8d48461 into Eyescale:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants